Skip to content

Firestore Spec Tests: Port JS PR 7372 (remove no-ios tag from bloom filter tests) #5088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

dconeybe
Copy link
Contributor

Sync spec tests with changes from firebase/firebase-js-sdk#7372: "Remove the no-ios tag from bloom filter spec tests".

The changes in this PR have no effect on this SDK, but serves to keep the spec tests in sync for easier updating in the future.

#no-changelog

@github-actions
Copy link
Contributor

github-actions bot commented Jun 20, 2023

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 44.34% (63f2071) to 44.32% (e6992ba) by -0.02%.

    FilenameBase (63f2071)Merge (e6992ba)Diff
    DeleteMutation.java95.24%90.48%-4.76%
    LruGarbageCollector.java97.27%93.64%-3.64%
    PatchMutation.java100.00%98.39%-1.61%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/2DsEXX6qo3.html

@github-actions
Copy link
Contributor

Unit Test Results

   162 files  +  39     162 suites  +39   1m 52s ⏱️ - 6m 57s
1 162 tests  -     3  1 146 ✔️  -   17  16 💤 +16  0  - 2 
2 324 runs  +971  2 292 ✔️ +941  32 💤 +32  0  - 2 

Results for commit fc4b907. ± Comparison against base commit 63f2071.

@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-fst

    DeviceStatisticsDistributions
    oriole-32
    Percentile63f2071e6992baDiffSignificant (?)
    p10320 ±16 μs319 ±15 μs-749 ns (-0.2%)NO
    p25332 ±22 μs332 ±22 μs-275 ns (-0.1%)NO
    p50354 ±37 μs371 ±62 μs+17.6 μs (+5.0%)NO
    p75418 ±102 μs433 ±99 μs+14.9 μs (+3.6%)NO
    p90486 ±162 μs490 ±128 μs+4.41 μs (+0.9%)NO

    19 test runs in comparison
    CommitTest Runs
    63f2071
    • 2023-06-16_17:24:10.333081_bOMx
    • 2023-06-16_17:24:10.337151_mYRa
    • 2023-06-16_17:24:10.337175_aBce
    • 2023-06-16_17:24:10.337184_DMuZ
    • 2023-06-16_17:24:10.337191_lFzN
    • 2023-06-16_17:24:10.337199_fbAc
    • 2023-06-16_17:24:10.337207_mmpm
    • 2023-06-16_17:24:10.337220_jcjv
    • 2023-06-16_17:24:10.337228_yktB
    e6992ba
    • 2023-06-20_18:54:41.953106_hzJq
    • 2023-06-20_18:54:41.956271_dYpl
    • 2023-06-20_18:54:41.956287_WspY
    • 2023-06-20_18:54:41.956295_fPFr
    • 2023-06-20_18:54:41.956302_uTaQ
    • 2023-06-20_18:54:41.956309_Ypkd
    • 2023-06-20_18:54:41.956319_OSsF
    • 2023-06-20_18:54:41.956325_euXA
    • 2023-06-20_18:54:41.956332_OUol
    • 2023-06-20_18:54:41.956338_zNkf
    redfin-30
    Percentile63f2071e6992baDiffSignificant (?)
    p10639 ±39 μs632 ±38 μs-7.24 μs (-1.1%)NO
    p25657 ±45 μs652 ±43 μs-5.29 μs (-0.8%)NO
    p50692 ±59 μs685 ±52 μs-6.91 μs (-1.0%)NO
    p75731 ±72 μs726 ±55 μs-4.91 μs (-0.7%)NO
    p90811 ±127 μs789 ±87 μs-22.1 μs (-2.7%)NO

    19 test runs in comparison
    CommitTest Runs
    63f2071
    • 2023-06-16_17:24:10.333081_bOMx
    • 2023-06-16_17:24:10.337151_mYRa
    • 2023-06-16_17:24:10.337175_aBce
    • 2023-06-16_17:24:10.337184_DMuZ
    • 2023-06-16_17:24:10.337191_lFzN
    • 2023-06-16_17:24:10.337199_fbAc
    • 2023-06-16_17:24:10.337207_mmpm
    • 2023-06-16_17:24:10.337220_jcjv
    • 2023-06-16_17:24:10.337228_yktB
    e6992ba
    • 2023-06-20_18:54:41.953106_hzJq
    • 2023-06-20_18:54:41.956271_dYpl
    • 2023-06-20_18:54:41.956287_WspY
    • 2023-06-20_18:54:41.956295_fPFr
    • 2023-06-20_18:54:41.956302_uTaQ
    • 2023-06-20_18:54:41.956309_Ypkd
    • 2023-06-20_18:54:41.956319_OSsF
    • 2023-06-20_18:54:41.956325_euXA
    • 2023-06-20_18:54:41.956332_OUol
    • 2023-06-20_18:54:41.956338_zNkf
  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentile63f2071e6992baDiffSignificant (?)
    p10191 ±4 ms196 ±2 ms+4.68 ms (+2.4%)NO
    p25198 ±3 ms201 ±2 ms+3.24 ms (+1.6%)NO
    p50205 ±4 ms210 ±2 ms+4.22 ms (+2.1%)NO
    p75214 ±4 ms219 ±2 ms+4.56 ms (+2.1%)NO
    p90223 ±4 ms234 ±8 ms+10.8 ms (+4.8%)NO

    19 test runs in comparison
    CommitTest Runs
    63f2071
    • 2023-06-16_17:24:10.333081_bOMx
    • 2023-06-16_17:24:10.337151_mYRa
    • 2023-06-16_17:24:10.337175_aBce
    • 2023-06-16_17:24:10.337184_DMuZ
    • 2023-06-16_17:24:10.337191_lFzN
    • 2023-06-16_17:24:10.337199_fbAc
    • 2023-06-16_17:24:10.337207_mmpm
    • 2023-06-16_17:24:10.337220_jcjv
    • 2023-06-16_17:24:10.337228_yktB
    e6992ba
    • 2023-06-20_18:54:41.953106_hzJq
    • 2023-06-20_18:54:41.956271_dYpl
    • 2023-06-20_18:54:41.956287_WspY
    • 2023-06-20_18:54:41.956295_fPFr
    • 2023-06-20_18:54:41.956302_uTaQ
    • 2023-06-20_18:54:41.956309_Ypkd
    • 2023-06-20_18:54:41.956319_OSsF
    • 2023-06-20_18:54:41.956325_euXA
    • 2023-06-20_18:54:41.956332_OUol
    • 2023-06-20_18:54:41.956338_zNkf
    redfin-30
    Percentile63f2071e6992baDiffSignificant (?)
    p10231 ±4 ms253 ±3 ms+21.7 ms (+9.4%)YES
    p25236 ±4 ms258 ±3 ms+21.9 ms (+9.3%)YES
    p50243 ±5 ms266 ±3 ms+22.9 ms (+9.4%)MAYBE
    p75252 ±5 ms275 ±4 ms+23.0 ms (+9.1%)MAYBE
    p90260 ±7 ms289 ±5 ms+29.8 ms (+11.5%)MAYBE

    19 test runs in comparison
    CommitTest Runs
    63f2071
    • 2023-06-16_17:24:10.333081_bOMx
    • 2023-06-16_17:24:10.337151_mYRa
    • 2023-06-16_17:24:10.337175_aBce
    • 2023-06-16_17:24:10.337184_DMuZ
    • 2023-06-16_17:24:10.337191_lFzN
    • 2023-06-16_17:24:10.337199_fbAc
    • 2023-06-16_17:24:10.337207_mmpm
    • 2023-06-16_17:24:10.337220_jcjv
    • 2023-06-16_17:24:10.337228_yktB
    e6992ba
    • 2023-06-20_18:54:41.953106_hzJq
    • 2023-06-20_18:54:41.956271_dYpl
    • 2023-06-20_18:54:41.956287_WspY
    • 2023-06-20_18:54:41.956295_fPFr
    • 2023-06-20_18:54:41.956302_uTaQ
    • 2023-06-20_18:54:41.956309_Ypkd
    • 2023-06-20_18:54:41.956319_OSsF
    • 2023-06-20_18:54:41.956325_euXA
    • 2023-06-20_18:54:41.956332_OUol
    • 2023-06-20_18:54:41.956338_zNkf

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/i4mz1wHK9Q/index.html

@dconeybe dconeybe requested a review from milaGGL June 21, 2023 00:13
Copy link
Contributor

@milaGGL milaGGL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dconeybe dconeybe merged commit dd710a7 into master Jun 21, 2023
@dconeybe dconeybe deleted the dconeybe/BloomFilterSpecTestsIosEnable branch June 21, 2023 05:14
@firebase firebase locked and limited conversation to collaborators Jul 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants