Skip to content

Update compat typing for app #7294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 25, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/shaggy-donkeys-know.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'firebase': patch
---

Update `/compat/app` type path to accommodate the new `"moduleResolution": "bundler"` mode of TypeScript 5.0+.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is too specific, this is not a special accommodation for TypeScript 5, it was just wrong in the first place. Simply "Fixed the types path for compat/app" should work.

If you want to make sure this is linked back to the original bug report, you can put "Fixes [link to bug]" in the PR description. This will close the issue once you merge this, and it will appear as ("fixes #xxxx") in the Version Packages PR during release which will make it easy for the release operator to follow the link and understand the background.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! I'll update the changeset

2 changes: 1 addition & 1 deletion packages/firebase/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@
"default": "./compat/analytics/dist/esm/index.esm.js"
},
"./compat/app": {
"types": "./compat/app/dist/compat/app/index.d.ts",
"types": "./compat/index.d.ts",
"node": {
"require": "./compat/app/dist/index.cjs.js",
"import": "./compat/app/dist/index.mjs"
Expand Down