Update compat typing for app #7294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9cac66b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (147,946 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
DellaBitta
approved these changes
May 16, 2023
hsubox76
reviewed
May 22, 2023
hsubox76
reviewed
May 24, 2023
.changeset/shaggy-donkeys-know.md
Outdated
| 'firebase': patch | ||
| --- | ||
|
|
||
| Update `/compat/app` type path to accommodate the new `"moduleResolution": "bundler"` mode of TypeScript 5.0+. |
There was a problem hiding this comment.
This is too specific, this is not a special accommodation for TypeScript 5, it was just wrong in the first place. Simply "Fixed the types path for compat/app" should work.
If you want to make sure this is linked back to the original bug report, you can put "Fixes [link to bug]" in the PR description. This will close the issue once you merge this, and it will appear as ("fixes #xxxx") in the Version Packages PR during release which will make it easy for the release operator to follow the link and understand the background.
There was a problem hiding this comment.
Sounds good! I'll update the changeset
hsubox76
approved these changes
May 24, 2023
Merged
ch5zzy
pushed a commit
that referenced
this pull request
Jun 6, 2023
* Update compat typing for app * Add changeset * Update changeset * Update changeset * Revert update to node-fetch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
/compat/apptype path to deliver the proper typings to the compat packages. Fixes #7279