You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up to #7095 to clean up and improve some of the logic added to the 'resuming a query should use bloom filter to avoid full requery' test.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
…ions failure (patched in from #7088)"
The tests all passed with this patch. It would seem that running tests in parallel is problematic.
Try to revert this commit and see if we get lucky.
This reverts commit b224a4f.
FYI I can't figure out the failures of "Test Firestore / Test Firestore on Firefox If Changed (pull_request)". It appears to be completely unrelated to this PR and passes easily if I tweak the scripts to run the tests sequentially rather than in parallel (see the last two commits in this PR). I think you can just ignore that failing check.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #7095 to clean up and improve some of the logic added to the 'resuming a query should use bloom filter to avoid full requery' test.
Ported to Android in Ported to Android in firebase/firebase-android-sdk#4768.