Skip to content

Bloom filter gha failure fix b/271461549 #7088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 18 commits into from
Closed

Bloom filter gha failure fix b/271461549 #7088

wants to merge 18 commits into from

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Mar 2, 2023

No description provided.

@dconeybe dconeybe self-assigned this Mar 2, 2023
@changeset-bot
Copy link

changeset-bot bot commented Mar 2, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1e44e25

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 2, 2023 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (7c20d7d) and merge commit (c586301).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/WnZazHdpzC.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 2, 2023 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (7c20d7d) and merge commit (c586301).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/s7ZAOFt2X8.html

dconeybe added 16 commits March 2, 2023 21:09
@dconeybe
Merge remote-tracking branch 'remotes/origin/mila/BloomFilter' into B…
8c87e42 
…loomFilterGhaFailureFixBug271461549
@dconeybe
package.json: run-p -> run-s to remove another source of parallelism …
4964e44 
…that could be hiding the root cause of the failure
@dconeybe
scripts/run-tests.ts: add logging
20e2f5e
@dconeybe
scripts/run-tests.ts: fix linting errors
6dab194
@dconeybe
scripts/run-tests.ts: make timestamp in log messages more human friendly
8c557d6
@dconeybe
Remove check-changeset.yml because it annonyingly always fails when u…
3569940 
…sing any branch other than 'master' as the base branch of a PR
@dconeybe
scripts/run_tests_in_ci.js: add more helpful debug logging output
6f0304a
@dconeybe
scripts/run_tests_in_ci.js: fix typo and add dividers for stdout/stderr
3a5f602
@dconeybe
more script log output additions
fc60e9b
@dconeybe
scripts/run_tests_in_ci.js: remove TypeScript code from JavaScript so…
5992b88 
…urce
@dconeybe
scripts/ci-test/test_changed.ts: fix formatting
26edb30
@dconeybe
replace performance.now() with process.hrtime()
c2e5d78
@dconeybe
scripts/run_tests_in_ci.js: fix formatting
28a86f2
@dconeybe
firestore/scripts/run-tests.ts: use errorLog() to log errors, rather …
97e75ba 
…than debugLog().
@dconeybe
make logging more palletable
6cf93f8
@dconeybe
Merge remote-tracking branch 'remotes/origin/mila/BloomFilter' into HEAD
1e44e25
dconeybe added a commit that referenced this pull request Mar 11, 2023
@dconeybe
REVERT ME: Add some extra logging to help diagnose github actions fai…
b224a4f 
…lure (patched in from #7088)
dconeybe added a commit that referenced this pull request Mar 11, 2023
@dconeybe
Revert "REVERT ME: Add some extra logging to help diagnose github act…
3b60c56 
…ions failure (patched in from #7088)"

The tests all passed with this patch. It would seem that running tests in parallel is problematic.

Try to revert this commit and see if we get lucky.

This reverts commit b224a4f.
@dconeybe dconeybe closed this Mar 17, 2023
@dconeybe dconeybe deleted the dconeybe/BloomFilterGhaFailureFixBug271461549 branch March 17, 2023 16:18
@firebase firebase locked and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@dconeybe dconeybe

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dconeybe @google-oss-bot