Skip to content

updating database package dependency to add required peer dependency #6818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

john-arccos
Copy link

Hi! I noticed this warning when using firebase-admin in our app.

I was going through the test set up and was almost complete, but then it asked me to switch to the "pay as you go" plan. I'm not sure I feel comfortable signing up for that as I'm pretty unfamiliar with firebase and mostly just want to clean up our dependency tree. I don't really want to pay money just to run this test suite. Please advise on how to continue.

This is the warning we got when running yarn:

➤ YN0000: ┌ Resolution step
➤ YN0002: │ @firebase/database@npm:0.13.10 doesn't provide @firebase/app-types (pc007b), requested by @firebase/auth-interop-types

and when I use yarn link to link this version of @firebase/database that warning goes away.

@changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2022

🦋 Changeset detected

Latest commit: b53240f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/database Patch
@firebase/database-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-cla
Copy link

google-cla bot commented Nov 21, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@hsubox76
Copy link
Contributor

We're looking into fixing this. The source of this issue is somewhat complex and has to do with the fact that the @firebase/database package is used both in the JS SDK and as a dependency of the Admin Node SDK, and that each use case really requires a different package.json (the Admin Node version should not depend on app or app-types at all), but we've been hacking solutions so far by trying to make a package.json that somehow works for both.

It seems to me with increasing Yarn2 and PNPM problems that this isn't sustainable anymore and we may need to go ahead and make a separate NPM package for the database package consumed by Admin SDK.

Related ongoing issues:
#3707
firebase/firebase-admin-node#973

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants