FR: Make firebase compatible with Yarn2 pnp

[ScottPierce]

[REQUIRED] Describe the problem

I get an error when bundling with Yarn 2 and firebase:

(node:82642) [MODULE_NOT_FOUND] Error: @firebase/database tried to access @firebase/app, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.

Steps to reproduce:

I'm building a create-react-app application with yarn2 with pnp that depends on firebase, and it outputs the following error:

(node:82642) [MODULE_NOT_FOUND] Error: @firebase/database tried to access @firebase/app, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.

[google-oss-bot]

I found a few problems with this issue:

• I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
• This issue does not have all the information required by the template. Looks like you forgot to fill out some sections. Please update the issue with more information.

[Feiyang1]

Thanks for the report! Are you able to get it to work using loose mode (I tried it, but it still didn't work)? Otherwise I'm afraid firebase is not compatible with yarn 2 pnp at the moment.

As the message states, @firebase/app is not declared as a dependency for @firebase/database. This is for working around the unmet peerDependency warning for firebase-admin users (see this PR). I admit it is not an ideal solution and we probably should create a separate npm package to be used in firebase-admin, so we can list dependencies correctly.

I will keep it open as a feature request, but it is probably a low priority for us right now.
@hiranya911 FYI

[PutziSan]

This problem is still there.

Currently workaround is adding this to .yarnrc.yml

packageExtensions:
  # https://github.com/firebase/firebase-js-sdk/issues/3707
  "@firebase/database@*":
    peerDependencies:
      "@firebase/app": "*"
      "@firebase/app-types": "*"

info about packageExtensions:

Some packages may have been specified incorrectly with regard to their dependencies - for example with one dependency being missing, causing Yarn to refuse it the access. The packageExtensions fields offer a way to extend the existing package definitions with additional information.

https://yarnpkg.com/configuration/yarnrc#packageExtensions

[Zloka]

Thanks for the report! Are you able to get it to work using loose mode (I tried it, but it still didn't work)? Otherwise I'm afraid firebase is not compatible with yarn 2 pnp at the moment.

As the message states, @firebase/app is not declared as a dependency for @firebase/database. This is for working around the unmet peerDependency warning for firebase-admin users (see this PR). I admit it is not an ideal solution and we probably should create a separate npm package to be used in firebase-admin, so we can list dependencies correctly.

I will keep it open as a feature request, but it is probably a low priority for us right now.
@hiranya911 FYI

@Feiyang1 not sure what the correct place and practice for bumping feature requests is, and I understand the low priority, but for what it is worth our team would like to make use of Yarn PnP as well, and ended up here 🙂

[mikob]

This problem is still there.

Currently workaround is adding this to .yarnrc.yml

packageExtensions:
  # https://github.com/firebase/firebase-js-sdk/issues/3707
  "@firebase/database@*":
    peerDependencies:
      "@firebase/app": "*"
      "@firebase/app-types": "*"

info about packageExtensions:

Some packages may have been specified incorrectly with regard to their dependencies - for example with one dependency being missing, causing Yarn to refuse it the access. The packageExtensions fields offer a way to extend the existing package definitions with additional information.

https://yarnpkg.com/configuration/yarnrc#packageExtensions

Thank you @PutziSan for the headstart. I needed the following for firebase v9:

  "@firebase/auth@*":
    dependencies:
      "@firebase/app": "*"
      "@firebase/app-types": "*"
  "firebase@*":
    dependencies:
      "@firebase/auth": "*"
      "@firebase/app": "*"
  "@lipsurf/extension@*":  # the project that uses firebase
    dependencies:
      "@vue/runtime-core": "*"
      "@firebase/auth": "*"
      "@firebase/app": "*"
      "@firebase/app-types": "*"