Skip to content

change int32 to int64 #6577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 2, 2022
Merged

change int32 to int64 #6577

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08e4550
change int32 to int64
milaGGL Aug 31, 2022
2c667fa
resolve comments
milaGGL Sep 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/firestore/src/protos/google/firestore/v1/query.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ message StructuredAggregationQuery {
// Requires:
//
// * Must be greater than zero when present.
int32 up_to = 1;
int64 up_to = 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has to be google.protobuf.Int64Value.

See firebase/firebase-android-sdk#4038

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have google.protobuf.Int64Value in web sdk?
web sdk used google.protobuf.Int32Value, but didn't see any line uses google.protobuf.Int64Value. 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I believe we do have google.protobuf.Int64Value in the web sdk. Even if we don't it's fine because we never use it. But it's important that the proto definition is correct because if we ever do use it in the future then we want it to work correctly. Are you encountering errors when you change it to Int64Value?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, no errors

}

// The type of aggregation to perform, required.
Expand Down