Skip to content

Upgrade count upto to use int64 #4038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 30, 2022
Merged

Upgrade count upto to use int64 #4038

merged 2 commits into from
Aug 30, 2022

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Aug 29, 2022

No description provided.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 29, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 44.37% (3f13291) to 44.41% (91f9a6b) by +0.04%.

    FilenameBase (3f13291)Merge (91f9a6b)Diff
    AbstractStream.java37.02%34.81%-2.21%
    AsyncQueue.java78.11%78.61%+0.50%
    Datastore.java21.55%23.28%+1.72%
    FirestoreChannel.java16.38%18.10%+1.72%
    FirestoreClient.java31.25%36.11%+4.86%
    GrpcCallProvider.java62.35%69.41%+7.06%
    IndexBackfiller.java89.06%93.75%+4.69%
    LruGarbageCollector.java90.65%93.46%+2.80%
    SetMutation.java97.22%94.44%-2.78%
    SQLitePersistence.java86.89%86.34%-0.55%

Test Logs

Notes

  • Commit (91f9a6b) is created by Prow via merging PR base commit (3f13291) and head commit (fb4155c).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/0wQ9fpgbpg.html

@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2022 •
edited
Loading

Unit Test Results

1 097 tests  ±0   1 081 ✔️ ±0   1m 10s ⏱️ -5s
     79 suites ±0        16 💤 ±0 
     79 files   ±0          0 ❌ ±0 

Results for commit fb4155c. ± Comparison against base commit a50da9f.

♻️ This comment has been updated with latest results.

@wu-hui wu-hui requested a review from dconeybe August 29, 2022 15:09
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 29, 2022 •
edited
Loading

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (3f13291)Merge (91f9a6b)Diff
    aar1.30 MB1.31 MB+580 B (+0.0%)
    apk (aggressive)493 kB493 kB+8 B (+0.0%)
    apk (release)3.33 MB3.33 MB+248 B (+0.0%)

Test Logs

Notes

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/KEA0cTUVPb.html

dconeybe
dconeybe reviewed Aug 29, 2022
View reviewed changes
firebase-firestore/src/proto/google/firestore/v1/query.proto Outdated
@@ -313,7 +313,7 @@ message StructuredAggregationQuery {
// Requires:
//
// * Must be greater than zero when present.
int32 up_to = 1;
int64 up_to = 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be google.protobuf.Int64Value, no? Or is that the same thing?

https://github.com/googleapis/googleapis/blob/260b98fa50c7e16634262b4c0ade2429cfb18f20/google/firestore/v1/query.proto#L323

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It really looks like int64 and google.protobuf.Int64Value are distinct types.

https://github.com/protocolbuffers/protobuf/blob/91cda68a22c999f37aa4671896e6a314bac5881d/src/google/protobuf/wrappers.proto#L69-L75

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@dconeybe dconeybe assigned wu-hui and unassigned dconeybe Aug 29, 2022
@wu-hui wu-hui merged commit 42c8d72 into master Aug 30, 2022
@wu-hui wu-hui deleted the wuandy/upto64 branch August 30, 2022 13:48
@dconeybe dconeybe mentioned this pull request Sep 1, 2022
Merged
@firebase firebase locked and limited conversation to collaborators Sep 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dconeybe dconeybe dconeybe approved these changes

Assignees

@wu-hui wu-hui

Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wu-hui @google-oss-bot @dconeybe