Skip to content

Revert "Revert "Tomandersen/multi db"" -- and make api internal #6554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 25, 2022
Merged

Revert "Revert "Tomandersen/multi db"" -- and make api internal #6554

merged 4 commits into from
Aug 25, 2022

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Aug 23, 2022

Reverts #6552

@changeset-bot
Copy link

changeset-bot bot commented Aug 23, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6db1afb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 23, 2022 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/analytics

    TypeBase (474025c)Merge (02d211f)Diff
    browser?20.1 kB? (?)
    esm5?24.7 kB? (?)
    main?26.0 kB? (?)
    module?20.1 kB? (?)

  • @firebase/analytics-compat

    TypeBase (474025c)Merge (02d211f)Diff
    browser?2.57 kB? (?)
    esm5?2.80 kB? (?)
    main?3.24 kB? (?)
    module?2.57 kB? (?)

  • @firebase/api-documenter

    TypeBase (474025c)Merge (02d211f)Diff
    main?3.95 kB? (?)

  • @firebase/app

    TypeBase (474025c)Merge (02d211f)Diff
    browser?14.1 kB? (?)
    esm5?18.4 kB? (?)
    main?19.3 kB? (?)
    module?14.1 kB? (?)

  • @firebase/app-check

    TypeBase (474025c)Merge (02d211f)Diff
    browser?25.2 kB? (?)
    esm5?29.9 kB? (?)
    main?31.1 kB? (?)
    module?25.2 kB? (?)

  • @firebase/app-check-compat

    TypeBase (474025c)Merge (02d211f)Diff
    browser?2.27 kB? (?)
    esm5?2.48 kB? (?)
    main?2.94 kB? (?)
    module?2.27 kB? (?)

  • @firebase/app-compat

    TypeBase (474025c)Merge (02d211f)Diff
    browser?5.28 kB? (?)
    esm5?6.13 kB? (?)
    lite?4.06 kB? (?)
    main?6.73 kB? (?)
    module?5.28 kB? (?)

  • @firebase/auth

    TypeBase (474025c)Merge (02d211f)Diff
    browser?155 kB? (?)
    cordova?183 kB? (?)
    esm5?203 kB? (?)
    main?148 kB? (?)
    module?155 kB? (?)
    react-native?168 kB? (?)

  • @firebase/auth-compat

    TypeBase (474025c)Merge (02d211f)Diff
    browser?20.2 kB? (?)
    esm5?27.1 kB? (?)
    main?29.6 kB? (?)
    module?20.2 kB? (?)

  • @firebase/auth/cordova

    TypeBase (474025c)Merge (02d211f)Diff
    browser?183 kB? (?)
    module?183 kB? (?)

  • @firebase/auth/internal

    TypeBase (474025c)Merge (02d211f)Diff
    browser?166 kB? (?)
    esm5?216 kB? (?)
    main?184 kB? (?)
    module?166 kB? (?)

  • @firebase/auth/react-native

    TypeBase (474025c)Merge (02d211f)Diff
    browser?168 kB? (?)
    module?168 kB? (?)

  • @firebase/component

    TypeBase (474025c)Merge (02d211f)Diff
    browser?6.54 kB? (?)
    esm5?8.61 kB? (?)
    main?8.99 kB? (?)
    module?6.54 kB? (?)

  • @firebase/database

    TypeBase (474025c)Merge (02d211f)Diff
    browser?248 kB? (?)
    esm5?276 kB? (?)
    main?281 kB? (?)
    module?248 kB? (?)

  • @firebase/database-compat

    TypeBase (474025c)Merge (02d211f)Diff
    browser?18.0 kB? (?)
    esm5?21.1 kB? (?)
    main?21.8 kB? (?)
    module?18.0 kB? (?)

  • @firebase/database-compat/standalone

    TypeBase (474025c)Merge (02d211f)Diff
    main?370 kB? (?)

  • @firebase/firestore

    TypeBase (474025c)Merge (02d211f)Diff
    browser?264 kB? (?)
    esm5?327 kB? (?)
    main?525 kB? (?)
    module?264 kB? (?)
    react-native?264 kB? (?)

  • @firebase/firestore-compat

    TypeBase (474025c)Merge (02d211f)Diff
    browser?20.5 kB? (?)
    esm5?27.6 kB? (?)
    main?20.9 kB? (?)
    module?20.5 kB? (?)
    react-native?20.5 kB? (?)

  • @firebase/firestore-lite

    TypeBase (474025c)Merge (02d211f)Diff
    browser?80.8 kB? (?)
    esm5?96.6 kB? (?)
    main?136 kB? (?)
    module?80.8 kB? (?)
    react-native?81.0 kB? (?)

  • @firebase/functions

    TypeBase (474025c)Merge (02d211f)Diff
    browser?9.39 kB? (?)
    esm5?11.5 kB? (?)
    main?12.4 kB? (?)
    module?9.39 kB? (?)

  • @firebase/functions-compat

    TypeBase (474025c)Merge (02d211f)Diff
    browser?1.79 kB? (?)
    esm5?1.98 kB? (?)
    main?2.34 kB? (?)
    module?1.79 kB? (?)

  • @firebase/installations

    TypeBase (474025c)Merge (02d211f)Diff
    browser?17.8 kB? (?)
    esm5?22.9 kB? (?)
    main?23.8 kB? (?)
    module?17.8 kB? (?)

  • @firebase/installations-compat

    TypeBase (474025c)Merge (02d211f)Diff
    browser?945 B? (?)
    esm5?1.16 kB? (?)
    main?1.49 kB? (?)
    module?945 B? (?)

  • @firebase/logger

    TypeBase (474025c)Merge (02d211f)Diff
    esm5?4.65 kB? (?)
    main?5.32 kB? (?)
    module?3.25 kB? (?)

  • @firebase/messaging

    TypeBase (474025c)Merge (02d211f)Diff
    browser?21.3 kB? (?)
    esm5?26.7 kB? (?)
    main?27.4 kB? (?)
    module?21.3 kB? (?)

  • @firebase/messaging-compat

    TypeBase (474025c)Merge (02d211f)Diff
    browser?2.08 kB? (?)
    esm5?2.51 kB? (?)
    main?2.90 kB? (?)
    module?2.08 kB? (?)

  • @firebase/messaging-sw

    TypeBase (474025c)Merge (02d211f)Diff
    main?30.1 kB? (?)
    module?23.3 kB? (?)

  • @firebase/performance

    TypeBase (474025c)Merge (02d211f)Diff
    browser?29.1 kB? (?)
    esm5?30.8 kB? (?)
    main?31.2 kB? (?)
    module?29.1 kB? (?)

  • @firebase/performance-compat

    TypeBase (474025c)Merge (02d211f)Diff
    browser?1.10 kB? (?)
    esm5?1.38 kB? (?)
    main?1.69 kB? (?)
    module?1.10 kB? (?)

  • @firebase/remote-config

    TypeBase (474025c)Merge (02d211f)Diff
    browser?19.2 kB? (?)
    esm5?24.0 kB? (?)
    main?25.2 kB? (?)
    module?19.2 kB? (?)

  • @firebase/remote-config-compat

    TypeBase (474025c)Merge (02d211f)Diff
    browser?1.85 kB? (?)
    esm5?2.76 kB? (?)
    main?3.09 kB? (?)
    module?1.85 kB? (?)

  • @firebase/rules-unit-testing

    TypeBase (474025c)Merge (02d211f)Diff
    main?17.6 kB? (?)

  • @firebase/storage

    TypeBase (474025c)Merge (02d211f)Diff
    browser?54.5 kB? (?)
    esm5?60.5 kB? (?)
    main?57.4 kB? (?)
    module?54.5 kB? (?)

  • @firebase/storage-compat

    TypeBase (474025c)Merge (02d211f)Diff
    browser?5.67 kB? (?)
    esm5?8.41 kB? (?)
    main?8.82 kB? (?)
    module?5.67 kB? (?)

  • @firebase/util

    TypeBase (474025c)Merge (02d211f)Diff
    browser?21.0 kB? (?)
    esm5?22.3 kB? (?)
    main?27.3 kB? (?)
    module?21.0 kB? (?)

  • @firebase/webchannel-wrapper

    TypeBase (474025c)Merge (02d211f)Diff
    esm5?44.7 kB? (?)
    main?50.8 kB? (?)
    module?43.2 kB? (?)

  • bundle

    43 size changes

    TypeBase (474025c)Merge (02d211f)Diff
    analytics (logEvent)?41.9 kB? (?)
    app-check (CustomProvider)?35.5 kB? (?)
    app-check (ReCaptchaEnterpriseProvider)?37.7 kB? (?)
    app-check (ReCaptchaV3Provider)?37.7 kB? (?)
    auth (Anonymous)?66.4 kB? (?)
    auth (EmailAndPassword)?70.5 kB? (?)
    auth (GoogleFBTwitterGitHubPopup)?90.4 kB? (?)
    auth (GooglePopup)?90.1 kB? (?)
    auth (GoogleRedirect)?90.3 kB? (?)
    auth (Phone)?76.6 kB? (?)
    database (Append to a list of data)?145 kB? (?)
    database (Filtering data)?144 kB? (?)
    database (Listen for child events)?160 kB? (?)
    database (Listen for value events + Detach listeners)?160 kB? (?)
    database (Listen for value events)?160 kB? (?)
    database (Read data once)?159 kB? (?)
    database (Save data as transactions)?162 kB? (?)
    database (Sort data)?145 kB? (?)
    database (Write data)?144 kB? (?)
    firestore (Persistence)?274 kB? (?)
    firestore (Query Cursors)?211 kB? (?)
    firestore (Query)?212 kB? (?)
    firestore (Read data once)?201 kB? (?)
    firestore (Realtime updates)?203 kB? (?)
    firestore (Transaction)?184 kB? (?)
    firestore (Write data)?184 kB? (?)
    firestore-lite (Query Cursors)?68.3 kB? (?)
    firestore-lite (Query)?71.5 kB? (?)
    firestore-lite (Read data once)?55.9 kB? (?)
    firestore-lite (Transaction)?80.4 kB? (?)
    firestore-lite (Write data)?65.6 kB? (?)
    functions (call)?29.3 kB? (?)
    messaging (send + receive)?45.3 kB? (?)
    performance (trace)?49.7 kB? (?)
    remote-config (getAndFetch)?44.3 kB? (?)
    storage (getBytes)?37.6 kB? (?)
    storage (getDownloadURL)?39.7 kB? (?)
    storage (getMetadata)?39.1 kB? (?)
    storage (list + listAll)?38.6 kB? (?)
    storage (updateMetadata)?39.4 kB? (?)
    storage (uploadBytes)?43.9 kB? (?)
    storage (uploadBytesResumable)?53.4 kB? (?)
    storage (uploadString)?44.2 kB? (?)

  • firebase

    31 size changes

    TypeBase (474025c)Merge (02d211f)Diff
    firebase-analytics-compat.js?25.8 kB? (?)
    firebase-analytics.js?24.9 kB? (?)
    firebase-app-check-compat.js?22.9 kB? (?)
    firebase-app-check.js?21.7 kB? (?)
    firebase-app-compat.js?27.8 kB? (?)
    firebase-app.js?87.7 kB? (?)
    firebase-auth-compat.js?125 kB? (?)
    firebase-auth-cordova.js?137 kB? (?)
    firebase-auth-react-native.js?148 kB? (?)
    firebase-auth.js?116 kB? (?)
    firebase-compat.js?739 kB? (?)
    firebase-database-compat.js?166 kB? (?)
    firebase-database.js?153 kB? (?)
    firebase-firestore-compat.js?314 kB? (?)
    firebase-firestore-lite.js?86.2 kB? (?)
    firebase-firestore.js?313 kB? (?)
    firebase-functions-compat.js?8.12 kB? (?)
    firebase-functions.js?6.93 kB? (?)
    firebase-installations-compat.js?13.2 kB? (?)
    firebase-installations.js?12.5 kB? (?)
    firebase-messaging-compat.js?38.2 kB? (?)
    firebase-messaging-sw.js?26.0 kB? (?)
    firebase-messaging.js?24.8 kB? (?)
    firebase-performance-compat.js?30.7 kB? (?)
    firebase-performance-standalone-compat.es2017.js?87.6 kB? (?)
    firebase-performance-standalone-compat.js?65.4 kB? (?)
    firebase-performance.js?30.7 kB? (?)
    firebase-remote-config-compat.js?27.3 kB? (?)
    firebase-remote-config.js?26.4 kB? (?)
    firebase-storage-compat.js?38.2 kB? (?)
    firebase-storage.js?36.7 kB? (?)

  • functions

    TypeBase (474025c)Merge (02d211f)Diff
    main?46 B? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/PZt75FTCS7.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 23, 2022 •
edited
Loading

Size Analysis Report 1

This report is too large (1,411,597 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/uDsfa73TWz.html

@wu-hui wu-hui requested a review from tom-andersen August 23, 2022 20:10
@github-actions github-actions bot added the doc-changes PRs that affect docs label Aug 23, 2022
tom-andersen
tom-andersen approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@tom-andersen tom-andersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wu-hui wu-hui merged commit dd9acd0 into master Aug 25, 2022
@wu-hui wu-hui deleted the revert-6552-revert-6518-tomandersen/multiDb branch August 25, 2022 13:48
@firebase firebase locked and limited conversation to collaborators Sep 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@tom-andersen tom-andersen tom-andersen approved these changes

@egilmorez egilmorez Awaiting requested review from egilmorez

@dwyfrequency dwyfrequency Awaiting requested review from dwyfrequency

Assignees

@egilmorez egilmorez

@tom-andersen tom-andersen

Labels
doc-changes PRs that affect docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wu-hui @google-oss-bot @hsubox76 @tom-andersen @egilmorez