Skip to content

Revert "Tomandersen/multi db" #6552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Aug 23, 2022

Reverts #6518

Unfortunately this cannot be public yet.

@changeset-bot
Copy link

changeset-bot bot commented Aug 23, 2022

⚠️ No Changeset found

Latest commit: e94e4be

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (dac1e4c)Merge (d56a7f9)Diff
    browser264 kB264 kB-194 B (-0.1%)
    esm5327 kB327 kB-178 B (-0.1%)
    main525 kB525 kB-378 B (-0.1%)
    module264 kB264 kB-194 B (-0.1%)
    react-native264 kB264 kB-194 B (-0.1%)
  • @firebase/firestore-lite

    TypeBase (dac1e4c)Merge (d56a7f9)Diff
    browser80.8 kB80.7 kB-146 B (-0.2%)
    esm596.6 kB96.5 kB-130 B (-0.1%)
    main136 kB136 kB-308 B (-0.2%)
    module80.8 kB80.7 kB-146 B (-0.2%)
    react-native81.0 kB80.9 kB-146 B (-0.2%)
  • bundle

    12 size changes

    TypeBase (dac1e4c)Merge (d56a7f9)Diff
    firestore (Persistence)274 kB274 kB-113 B (-0.0%)
    firestore (Query Cursors)211 kB211 kB-113 B (-0.1%)
    firestore (Query)212 kB212 kB-113 B (-0.1%)
    firestore (Read data once)201 kB200 kB-113 B (-0.1%)
    firestore (Realtime updates)203 kB203 kB-113 B (-0.1%)
    firestore (Transaction)184 kB184 kB-113 B (-0.1%)
    firestore (Write data)184 kB184 kB-113 B (-0.1%)
    firestore-lite (Query Cursors)68.3 kB68.2 kB-102 B (-0.1%)
    firestore-lite (Query)71.5 kB71.4 kB-102 B (-0.1%)
    firestore-lite (Read data once)55.9 kB55.8 kB-102 B (-0.2%)
    firestore-lite (Transaction)80.4 kB80.3 kB-102 B (-0.1%)
    firestore-lite (Write data)65.6 kB65.5 kB-102 B (-0.2%)

  • firebase

    TypeBase (dac1e4c)Merge (d56a7f9)Diff
    firebase-compat.js739 kB738 kB-30 B (-0.0%)
    firebase-firestore-compat.js314 kB314 kB-30 B (-0.0%)
    firebase-firestore-lite.js86.2 kB86.1 kB-145 B (-0.2%)
    firebase-firestore.js313 kB312 kB-194 B (-0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/GDzJ18VRdb.html

@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

Affected Products

  • @firebase/firestore

    • AbstractUserDataWriter

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size24.1 kB24.1 kB-31 B (-0.1%)
      size-with-ext-deps83.6 kB83.6 kB-30 B (-0.0%)
    • Bytes

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size17.6 kB17.6 kB-31 B (-0.2%)
      size-with-ext-deps77.1 kB77.1 kB-30 B (-0.0%)
    • CACHE_SIZE_UNLIMITED

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size16.4 kB16.4 kB-31 B (-0.2%)
      size-with-ext-deps75.8 kB75.8 kB-30 B (-0.0%)
    • CollectionReference

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size20.0 kB19.9 kB-31 B (-0.2%)
      size-with-ext-deps79.4 kB79.4 kB-30 B (-0.0%)
    • DocumentReference

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size20.0 kB19.9 kB-31 B (-0.2%)
      size-with-ext-deps79.4 kB79.4 kB-30 B (-0.0%)
    • DocumentSnapshot

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size23.4 kB23.4 kB-31 B (-0.1%)
      size-with-ext-deps82.9 kB82.9 kB-30 B (-0.0%)
    • FieldPath

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size19.1 kB19.0 kB-31 B (-0.2%)
      size-with-ext-deps78.5 kB78.5 kB-30 B (-0.0%)
    • FieldValue

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size16.4 kB16.4 kB-31 B (-0.2%)
      size-with-ext-deps75.9 kB75.8 kB-30 B (-0.0%)
    • Firestore

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size16.4 kB16.3 kB-31 B (-0.2%)
      size-with-ext-deps75.8 kB75.8 kB-30 B (-0.0%)
    • FirestoreError

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size16.4 kB16.3 kB-31 B (-0.2%)
      size-with-ext-deps75.8 kB75.8 kB-30 B (-0.0%)
    • GeoPoint

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size16.9 kB16.9 kB-31 B (-0.2%)
      size-with-ext-deps76.4 kB76.4 kB-30 B (-0.0%)
    • LoadBundleTask

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size17.2 kB17.2 kB-31 B (-0.2%)
      size-with-ext-deps76.7 kB76.6 kB-30 B (-0.0%)
    • Query

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size16.5 kB16.5 kB-31 B (-0.2%)
      size-with-ext-deps76.0 kB75.9 kB-30 B (-0.0%)
    • QueryConstraint

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size16.4 kB16.3 kB-31 B (-0.2%)
      size-with-ext-deps75.8 kB75.8 kB-30 B (-0.0%)
    • QueryDocumentSnapshot

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size23.4 kB23.4 kB-31 B (-0.1%)
      size-with-ext-deps82.9 kB82.9 kB-30 B (-0.0%)
    • QuerySnapshot

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size25.3 kB25.3 kB-31 B (-0.1%)
      size-with-ext-deps84.8 kB84.8 kB-30 B (-0.0%)
    • SnapshotMetadata

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size16.5 kB16.5 kB-31 B (-0.2%)
      size-with-ext-deps76.0 kB75.9 kB-30 B (-0.0%)
    • Timestamp

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size17.6 kB17.5 kB-31 B (-0.2%)
      size-with-ext-deps77.0 kB77.0 kB-30 B (-0.0%)
    • Transaction

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size49.7 kB49.7 kB-30 B (-0.1%)
      size-with-ext-deps109 kB109 kB-30 B (-0.0%)
    • WriteBatch

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size46.5 kB46.5 kB-30 B (-0.1%)
      size-with-ext-deps106 kB106 kB-30 B (-0.0%)
    • _DatabaseId

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size16.4 kB16.3 kB-31 B (-0.2%)
      size-with-ext-deps75.8 kB75.8 kB-30 B (-0.0%)
    • _DocumentKey

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size25.6 kB25.6 kB-31 B (-0.1%)
      size-with-ext-deps85.1 kB85.1 kB-30 B (-0.0%)
    • _EmptyAppCheckTokenProvider

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size16.5 kB16.4 kB-31 B (-0.2%)
      size-with-ext-deps75.9 kB75.9 kB-30 B (-0.0%)
    • _EmptyAuthCredentialsProvider

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size16.4 kB16.4 kB-31 B (-0.2%)
      size-with-ext-deps75.8 kB75.8 kB-30 B (-0.0%)
    • _FieldPath

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size18.8 kB18.8 kB-31 B (-0.2%)
      size-with-ext-deps78.3 kB78.2 kB-30 B (-0.0%)
    • _cast

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size17.1 kB17.1 kB-31 B (-0.2%)
      size-with-ext-deps76.6 kB76.6 kB-30 B (-0.0%)
    • _debugAssert

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size16.4 kB16.4 kB-31 B (-0.2%)
      size-with-ext-deps75.8 kB75.8 kB-30 B (-0.0%)
    • _isBase64Available

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size16.4 kB16.4 kB-31 B (-0.2%)
      size-with-ext-deps75.9 kB75.8 kB-30 B (-0.0%)
    • _logWarn

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size16.5 kB16.4 kB-31 B (-0.2%)
      size-with-ext-deps75.9 kB75.9 kB-30 B (-0.0%)
    • _validateIsNotUsedTogether

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size16.4 kB16.3 kB-31 B (-0.2%)
      size-with-ext-deps75.8 kB75.8 kB-30 B (-0.0%)
    • addDoc

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size116 kB116 kB-30 B (-0.0%)
      size-with-ext-deps177 kB177 kB-30 B (-0.0%)
    • arrayRemove

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size28.7 kB28.7 kB-31 B (-0.1%)
      size-with-ext-deps88.3 kB88.3 kB-30 B (-0.0%)
    • arrayUnion

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size28.7 kB28.7 kB-31 B (-0.1%)
      size-with-ext-deps88.3 kB88.3 kB-30 B (-0.0%)
    • clearIndexedDbPersistence

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size25.1 kB25.1 kB-31 B (-0.1%)
      size-with-ext-deps84.8 kB84.7 kB-30 B (-0.0%)
    • collection

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size20.7 kB20.6 kB-31 B (-0.1%)
      size-with-ext-deps80.2 kB80.2 kB-30 B (-0.0%)
    • collectionGroup

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size19.7 kB19.7 kB-31 B (-0.2%)
      size-with-ext-deps79.2 kB79.1 kB-30 B (-0.0%)
    • connectFirestoreEmulator

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size18.2 kB18.1 kB-31 B (-0.2%)
      size-with-ext-deps78.2 kB78.2 kB-30 B (-0.0%)
    • deleteDoc

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size107 kB107 kB-30 B (-0.0%)
      size-with-ext-deps168 kB168 kB-30 B (-0.0%)
    • deleteField

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size16.8 kB16.7 kB-31 B (-0.2%)
      size-with-ext-deps76.2 kB76.2 kB-30 B (-0.0%)
    • disableNetwork

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size95.8 kB95.7 kB-30 B (-0.0%)
      size-with-ext-deps156 kB156 kB-30 B (-0.0%)
    • doc

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size20.7 kB20.7 kB-31 B (-0.1%)
      size-with-ext-deps80.3 kB80.2 kB-30 B (-0.0%)
    • documentId

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size19.1 kB19.1 kB-31 B (-0.2%)
      size-with-ext-deps78.6 kB78.5 kB-30 B (-0.0%)
    • enableIndexedDbPersistence

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size174 kB174 kB-30 B (-0.0%)
      size-with-ext-deps235 kB235 kB-30 B (-0.0%)
    • enableMultiTabIndexedDbPersistence

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size207 kB207 kB-30 B (-0.0%)
      size-with-ext-deps268 kB268 kB-30 B (-0.0%)
    • enableNetwork

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size95.7 kB95.7 kB-30 B (-0.0%)
      size-with-ext-deps156 kB156 kB-30 B (-0.0%)
    • endAt

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size34.7 kB34.7 kB-31 B (-0.1%)
      size-with-ext-deps94.3 kB94.2 kB-30 B (-0.0%)
    • endBefore

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size34.7 kB34.7 kB-31 B (-0.1%)
      size-with-ext-deps94.3 kB94.2 kB-30 B (-0.0%)
    • ensureFirestoreConfigured

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size16.5 kB16.5 kB-31 B (-0.2%)
      size-with-ext-deps75.9 kB75.9 kB-30 B (-0.0%)
    • executeWrite

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size106 kB106 kB-30 B (-0.0%)
      size-with-ext-deps167 kB167 kB-30 B (-0.0%)
    • getDoc

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size132 kB132 kB-30 B (-0.0%)
      size-with-ext-deps193 kB193 kB-30 B (-0.0%)
    • getDocFromCache

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size88.8 kB88.8 kB-30 B (-0.0%)
      size-with-ext-deps149 kB149 kB-30 B (-0.0%)
    • getDocFromServer

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size132 kB132 kB-30 B (-0.0%)
      size-with-ext-deps193 kB193 kB-30 B (-0.0%)
    • getDocs

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size134 kB134 kB-30 B (-0.0%)
      size-with-ext-deps195 kB195 kB-30 B (-0.0%)
    • getDocsFromCache

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size96.3 kB96.3 kB-30 B (-0.0%)
      size-with-ext-deps156 kB156 kB-30 B (-0.0%)
    • getDocsFromServer

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size134 kB134 kB-30 B (-0.0%)
      size-with-ext-deps195 kB195 kB-30 B (-0.0%)
    • getFirestore

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size16.5 kB16.4 kB-114 B (-0.7%)
      size-with-ext-deps76.2 kB76.1 kB-113 B (-0.1%)
    • increment

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size17.2 kB17.2 kB-31 B (-0.2%)
      size-with-ext-deps76.7 kB76.6 kB-30 B (-0.0%)
    • initializeFirestore

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size17.1 kB17.0 kB-89 B (-0.5%)
      size-with-ext-deps77.0 kB76.9 kB-88 B (-0.1%)
    • limit

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size17.2 kB17.2 kB-31 B (-0.2%)
      size-with-ext-deps76.7 kB76.7 kB-30 B (-0.0%)
    • limitToLast

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size17.2 kB17.2 kB-31 B (-0.2%)
      size-with-ext-deps76.7 kB76.7 kB-30 B (-0.0%)
    • loadBundle

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size105 kB105 kB-30 B (-0.0%)
      size-with-ext-deps166 kB165 kB-30 B (-0.0%)
    • namedQuery

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size82.3 kB82.2 kB-30 B (-0.0%)
      size-with-ext-deps142 kB142 kB-30 B (-0.0%)
    • onSnapshot

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size135 kB135 kB-30 B (-0.0%)
      size-with-ext-deps195 kB195 kB-30 B (-0.0%)
    • onSnapshotsInSync

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size124 kB124 kB-30 B (-0.0%)
      size-with-ext-deps185 kB185 kB-30 B (-0.0%)
    • orderBy

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size21.5 kB21.5 kB-31 B (-0.1%)
      size-with-ext-deps81.0 kB81.0 kB-30 B (-0.0%)
    • query

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size16.4 kB16.4 kB-31 B (-0.2%)
      size-with-ext-deps75.9 kB75.8 kB-30 B (-0.0%)
    • queryEqual

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size26.1 kB26.1 kB-31 B (-0.1%)
      size-with-ext-deps85.6 kB85.6 kB-30 B (-0.0%)
    • refEqual

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size20.1 kB20.1 kB-31 B (-0.2%)
      size-with-ext-deps79.7 kB79.6 kB-30 B (-0.0%)
    • runTransaction

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size116 kB116 kB-30 B (-0.0%)
      size-with-ext-deps177 kB177 kB-30 B (-0.0%)
    • serverTimestamp

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size16.7 kB16.6 kB-31 B (-0.2%)
      size-with-ext-deps76.1 kB76.1 kB-30 B (-0.0%)
    • setDoc

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size115 kB115 kB-30 B (-0.0%)
      size-with-ext-deps176 kB176 kB-30 B (-0.0%)
    • setIndexConfiguration

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size84.9 kB84.9 kB-30 B (-0.0%)
      size-with-ext-deps145 kB145 kB-30 B (-0.0%)
    • setLogLevel

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size16.4 kB16.4 kB-31 B (-0.2%)
      size-with-ext-deps75.8 kB75.8 kB-30 B (-0.0%)
    • snapshotEqual

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size32.9 kB32.9 kB-31 B (-0.1%)
      size-with-ext-deps92.4 kB92.4 kB-30 B (-0.0%)
    • startAfter

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size34.7 kB34.7 kB-31 B (-0.1%)
      size-with-ext-deps94.3 kB94.2 kB-30 B (-0.0%)
    • startAt

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size34.7 kB34.7 kB-31 B (-0.1%)
      size-with-ext-deps94.3 kB94.2 kB-30 B (-0.0%)
    • terminate

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size16.5 kB16.4 kB-54 B (-0.3%)
      size-with-ext-deps76.1 kB76.1 kB-53 B (-0.1%)
    • updateDoc

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size116 kB116 kB-30 B (-0.0%)
      size-with-ext-deps177 kB177 kB-30 B (-0.0%)
    • waitForPendingWrites

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size96.2 kB96.2 kB-30 B (-0.0%)
      size-with-ext-deps157 kB157 kB-30 B (-0.0%)
    • where

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size41.1 kB41.1 kB-31 B (-0.1%)
      size-with-ext-deps101 kB101 kB-30 B (-0.0%)
    • writeBatch

      Size

      TypeBase (dac1e4c)Merge (d56a7f9)Diff
      size118 kB118 kB-30 B (-0.0%)
      size-with-ext-deps179 kB179 kB-30 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/6n7LHwH59y.html

@wu-hui wu-hui merged commit 474025c into master Aug 23, 2022
@wu-hui wu-hui deleted the revert-6518-tomandersen/multiDb branch August 23, 2022 18:46
wu-hui added a commit that referenced this pull request Aug 23, 2022
wu-hui added a commit that referenced this pull request Aug 25, 2022
* Revert "Revert "Tomandersen/multi db (#6518)" (#6552)"

This reverts commit 474025c.

* Make multidb internal for now

* Changeset

* Delete change log
@firebase firebase locked and limited conversation to collaborators Sep 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants