Skip to content

Fix missing token error in GitHub Actions #6409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 7, 2022
Merged

Fix missing token error in GitHub Actions #6409

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fb12f35
Create test.md
maneesht Jul 3, 2022
cde09a8
Attempt to receive the proper github token
maneesht Jul 3, 2022
8221285
Added conditional to label doc changes
maneesht Jul 4, 2022
b66a503
Moved workflow into a step
maneesht Jul 6, 2022
bca5ee9
Updated conditional
maneesht Jul 6, 2022
565a171
Removed conditional on github token
maneesht Jul 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/label-doc-changes.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,4 @@ jobs:
if: ${{steps.check-doc-changes.outputs.DOC_CHANGED == 'true'}}
with:
labels: doc-changes
github_token: ${{ secrets.OSS_BOT_GITHUB_TOKEN }}
github_token: ${{ secrets.OSS_BOT_GITHUB_TOKEN || github.token }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason we use the OSS_BOT_GITHUB_TOKEN here is that if you use the built-in github token, the result of this workflow will not trigger any other workflows. (https://docs.github.com/en/actions/using-workflows/triggering-a-workflow#triggering-a-workflow-from-a-workflow) This workflow is intended to trigger assign-tech-writers.yml which is why Fei ended up switching to this token.

This isn't the most critical workflow and we can probably risk the tech writers not automatically being added in some cases if it's not frequent. If this (a fork) is the standard workflow then we probably need to think of another solution.

Another possibility is to not assign tech writers in a separate workflow but as an additional step at the end of this one. I'm not sure why Fei originally didn't do that, but my guess is that he wanted the label to always trigger assigning tech writers, even if the label is added manually. I figure if you are consciously assigning the label manually, you probably will remember to add the tech writer. I think this might be the way to go?

2 changes: 1 addition & 1 deletion .github/workflows/update-api-reports.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
with:
# checkout HEAD commit instead of merge commit
ref: ${{ github.event.pull_request.head.sha }}
token: ${{ secrets.OSS_BOT_GITHUB_TOKEN }}
token: ${{ secrets.OSS_BOT_GITHUB_TOKEN || github.token }}
- name: Set up Node (14)
uses: actions/setup-node@v2
with:
Expand Down