Fix missing token error in GitHub Actions #6409
Conversation
|
maneesht
changed the title
| github_token: ${{ secrets.OSS_BOT_GITHUB_TOKEN || github.token }} |
There was a problem hiding this comment.
The reason we use the OSS_BOT_GITHUB_TOKEN here is that if you use the built-in github token, the result of this workflow will not trigger any other workflows. (https://docs.github.com/en/actions/using-workflows/triggering-a-workflow#triggering-a-workflow-from-a-workflow) This workflow is intended to trigger assign-tech-writers.yml which is why Fei ended up switching to this token.
This isn't the most critical workflow and we can probably risk the tech writers not automatically being added in some cases if it's not frequent. If this (a fork) is the standard workflow then we probably need to think of another solution.
Another possibility is to not assign tech writers in a separate workflow but as an additional step at the end of this one. I'm not sure why Fei originally didn't do that, but my guess is that he wanted the label to always trigger assigning tech writers, even if the label is added manually. I figure if you are consciously assigning the label manually, you probably will remember to add the tech writer. I think this might be the way to go?
Workflows created by forked repositories are failing with the error
Error: Input required and not supplied: token.In our actions we use
secrets.OSS_BOT_GITHUB_TOKENwhich is valid for PRs created from the same repository, however, secrets are not passed to forked repos, as mentioned here, causing the actions to fail on forked repositories. We should instead be using the passed tokengithub.token