Skip to content

Create production release workflow #6304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 26, 2022
Merged

Create production release workflow #6304

merged 5 commits into from
May 26, 2022

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented May 26, 2022 •
edited
Loading

This is the production version of the staging release workflow, added in:
#6279
#6291
#6294
#6296

It differs from the staging workflow in that

  • it does not create a changeset PR
  • it calls the release script with the --Production flag which:
    • writes tags to the Github repository afterwards
    • does not bump versions manually since the correct versions should already be merged to the release branch
  • it does not run E2E tests
  • when done, it notifies the logProduction endpoint on the release tracker instead of logStaging

I've also modified publishToCI() so that it checks if a version has already been published to NPM and skips publishing it if so.

@hsubox76 hsubox76 requested a review from allspain as a code owner May 26, 2022 21:06
@changeset-bot
Copy link

changeset-bot bot commented May 26, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: f167e1a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 26, 2022 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (568fd0d) and merge commit (84bb3e8).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Y4IoqpcT1m.html

lahirumaramba
lahirumaramba approved these changes May 26, 2022
View reviewed changes
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 26, 2022 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (568fd0d) and merge commit (84bb3e8).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/f11EQiIPy4.html

@hsubox76 hsubox76 merged commit 9614bbd into master May 26, 2022
@hsubox76 hsubox76 deleted the ch-prod-release branch May 26, 2022 23:11
@firebase firebase locked and limited conversation to collaborators Jun 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lahirumaramba lahirumaramba lahirumaramba approved these changes

@allspain allspain Awaiting requested review from allspain

@dwyfrequency dwyfrequency Awaiting requested review from dwyfrequency

Assignees

@hsubox76 hsubox76

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsubox76 @google-oss-bot @lahirumaramba