Create staging release workflow #6279
Conversation
|
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (587,792 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
| NPM_TOKEN_API_DOCUMENTER: ${{ secrets.NPM_TOKEN_API_DOCUMENTER }} | ||
| CI: true | ||
| - name: Launch E2E tests workflow | ||
| uses: peter-evans/repository-dispatch@v2 |
There was a problem hiding this comment.
This is a minor concern, but if we think there is a risk of passing tokens to a third party GHA, we could probably write our own action and host it in the same repo.
There was a problem hiding this comment.
Since it's pretty simple I changed it to just a curl.
| OPERATOR=${{ github.actor }} | ||
| curl -X POST -H "Content-Type:application/json" \ | ||
| -d "{\"version\":\"$BASE_VERSION\",\"tag\":\"$STAGING_VERSION\",\"date\":\"$DATE\",\"operator\":\"$OPERATOR\"}" \ | ||
| https://us-central1-feature-tracker-8ca2b.cloudfunctions.net/logStaging |
There was a problem hiding this comment.
hmm should we store the endpoint in a secret?
There was a problem hiding this comment.
Oh yeah, that's the way to do it. In fact I already did so for a couple of other workflows and forgot.
| OPERATOR=${{ github.actor }} | ||
| curl -X POST -H "Content-Type:application/json" \ | ||
| -d "{\"version\":\"$BASE_VERSION\",\"tag\":\"$STAGING_VERSION\",\"date\":\"$DATE\",\"operator\":\"$OPERATOR\"}" \ | ||
| https://us-central1-feature-tracker-8ca2b.cloudfunctions.net/logStaging |
There was a problem hiding this comment.
hmm should we store the endpoint in a secret?
Moving as many release tasks as possible out of local script and into Github Actions.
Try creating a workflow for staging first. If all works well, make one for production in a future PR.
repository_dispatchtrigger to make it easier to call from here)CDN steps will be run separately and manually in google3 after the NPM publish is done.