Skip to content

Add beforeAuthStateChanged fn export #6222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2022

Conversation

jamesdaniels
Copy link
Member

@jamesdaniels jamesdaniels commented May 5, 2022

Adding the fn export for middleware #6178

@changeset-bot
Copy link

changeset-bot bot commented May 5, 2022

⚠️ No Changeset found

Latest commit: 09cc4aa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • @firebase/auth/cordova

    TypeBase (fc38643)Merge (1280b9b)Diff
    browser183 kB183 kB+151 B (+0.1%)
    module183 kB183 kB+151 B (+0.1%)
  • @firebase/auth/internal

    TypeBase (fc38643)Merge (1280b9b)Diff
    browser166 kB166 kB+151 B (+0.1%)
    esm5216 kB216 kB+151 B (+0.1%)
    main183 kB183 kB+310 B (+0.2%)
    module166 kB166 kB+151 B (+0.1%)
  • @firebase/auth/react-native

    TypeBase (fc38643)Merge (1280b9b)Diff
    browser167 kB168 kB+302 B (+0.2%)
    module167 kB168 kB+302 B (+0.2%)
  • firebase

    TypeBase (fc38643)Merge (1280b9b)Diff
    firebase-auth-cordova.js470 kB471 kB+580 B (+0.1%)
    firebase-auth-react-native.js493 kB494 kB+739 B (+0.1%)
    firebase-auth.js416 kB416 kB+580 B (+0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Cmx0G4D0Ie.html

@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

Affected Products

  • @firebase/auth

    • beforeAuthStateChanged

      Size

      TypeBase (fc38643)Merge (1280b9b)Diff
      size?31.2 kB? (?)
      size-with-ext-deps?50.8 kB? (?)

      Dependency

      TypeBase (fc38643)Merge (1280b9b)Diff
      functions?

      49 dependencies

      _assert
      _castAuth
      _createError
      _emulatorUrl
      _errorWithCustomMessage
      _fail
      _getBrowserName
      _getClientVersion
      _getCurrentScheme
      _getFinalTarget
      _getInstance
      _getUserLanguage
      _initializeAuthInstance
      _isAndroid
      _isBlackBerry
      _isChromeIOS
      _isFirefox
      _isHttpOrHttps
      _isIEMobile
      _isOnline
      _isSafari
      _isWebOS
      _logError
      _logoutIfInvalidated
      _makeTaggedError
      _parseToken
      _performApiRequest
      _performFetchWithErrorHandling
      _persistenceKeyName
      _prodErrorMap
      _reloadWithoutSaving
      _tokenExpiresIn
      assertStringOrUndefined
      beforeAuthStateChanged
      createErrorInternal
      debugAssert
      debugFail
      deleteAccount
      extractProviderData
      getAccountInfo
      getIdTokenResult
      getVersionForPlatform
      isUserInvalidated
      mergeProviderData
      registerAuth
      reload
      requestStsToken
      secondsStringToMilliseconds
      utcTimestampToDateString

      ?
      classes?

      13 dependencies

      AuthImpl
      AuthInterop
      AuthMiddlewareQueue
      Delay
      FetchProvider
      InMemoryPersistence
      NetworkTimeout
      PersistenceUserManager
      ProactiveRefresh
      StsTokenManager
      Subscription
      UserImpl
      UserMetadata

      ?
      variables?

      DEFAULT_API_TIMEOUT_MS
      SERVER_ERROR_MAP
      _DEFAULT_AUTH_ERROR_FACTORY
      inMemoryPersistence
      instanceCache
      logClient
      name
      prodErrorMap
      version

      ?
      enums??

      External Dependency

      ModuleBase (fc38643)Merge (1280b9b)Diff
      @firebase/app?

      SDK_VERSION
      _registerComponent
      registerVersion

      ?
      @firebase/component?

      Component

      ?
      @firebase/logger?

      LogLevel
      Logger

      ?
      @firebase/util?

      ErrorFactory
      FirebaseError
      base64Decode
      createSubscribe
      getModularInstance
      getUA
      isBrowserExtension
      isMobileCordova
      isReactNative
      querystring

      ?
      tslib?

      __rest

      ?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/xPoSR6QQZB.html

@hsubox76 hsubox76 changed the base branch from sam-gc/on-abort to auth-middleware May 5, 2022 16:32
@hsubox76 hsubox76 changed the base branch from auth-middleware to sam-gc/on-abort May 5, 2022 16:33
@hsubox76 hsubox76 merged commit 6e8983c into sam-gc/on-abort May 5, 2022
@hsubox76 hsubox76 deleted the jamesdaniels/middleware-changes branch May 5, 2022 16:35
sam-gc pushed a commit that referenced this pull request May 5, 2022
sam-gc added a commit that referenced this pull request May 5, 2022
* Add onAbort and refactor middleware

* Update packages/auth/src/core/auth/middleware.test.ts

Co-authored-by: Yuchen Shi <[email protected]>

* Add beforeAuthStateChanged fn export (#6222)

* Make some doc comment changes (#6229)

Co-authored-by: Yuchen Shi <[email protected]>
Co-authored-by: James Daniels <[email protected]>
Co-authored-by: Christina Holland <[email protected]>
@firebase firebase locked and limited conversation to collaborators Jun 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants