Skip to content

[Auth] Add onAbort and refactor middleware #6178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 5, 2022
Merged

[Auth] Add onAbort and refactor middleware #6178

merged 4 commits into from
May 5, 2022

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Apr 25, 2022

I've refactored the middleware code to its own class since it got sufficiently complicated with the onAbort() callbacks.

@sam-gc sam-gc requested a review from avolkovi as a code owner April 25, 2022 20:42
@changeset-bot
Copy link

changeset-bot bot commented Apr 25, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 955f2dc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 25, 2022 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/auth/cordova

    TypeBase (00c55a3)Merge (1779c69)Diff
    browser182 kB183 kB+751 B (+0.4%)
    module182 kB183 kB+751 B (+0.4%)

  • @firebase/auth/internal

    TypeBase (00c55a3)Merge (1779c69)Diff
    browser165 kB166 kB+553 B (+0.3%)
    esm5215 kB216 kB+751 B (+0.3%)
    main182 kB183 kB+910 B (+0.5%)
    module165 kB166 kB+553 B (+0.3%)

  • @firebase/auth/react-native

    TypeBase (00c55a3)Merge (1779c69)Diff
    browser167 kB168 kB+902 B (+0.5%)
    module167 kB168 kB+902 B (+0.5%)

  • bundle

    TypeBase (00c55a3)Merge (1779c69)Diff
    auth (Anonymous)65.8 kB66.0 kB+206 B (+0.3%)
    auth (EmailAndPassword)69.9 kB70.1 kB+206 B (+0.3%)
    auth (GoogleFBTwitterGitHubPopup)89.7 kB89.9 kB+206 B (+0.2%)
    auth (GooglePopup)89.5 kB89.7 kB+206 B (+0.2%)
    auth (GoogleRedirect)89.7 kB89.9 kB+206 B (+0.2%)
    auth (Phone)75.9 kB76.1 kB+206 B (+0.3%)

  • firebase

    TypeBase (00c55a3)Merge (1779c69)Diff
    firebase-auth-compat.js124 kB124 kB+210 B (+0.2%)
    firebase-auth-cordova.js469 kB471 kB+1.93 kB (+0.4%)
    firebase-auth-react-native.js492 kB494 kB+2.09 kB (+0.4%)
    firebase-auth.js415 kB416 kB+1.64 kB (+0.4%)
    firebase-compat.js782 kB782 kB+210 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/oiexKC6Qur.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 25, 2022 •
edited
Loading

Size Analysis Report 1

This report is too large (127,517 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/RvaV1vlPj6.html

@sam-gc sam-gc force-pushed the auth-middleware branch from 3785b07 to 25c0b60 Compare May 4, 2022 21:18
@sam-gc sam-gc force-pushed the sam-gc/on-abort branch from 16e6460 to 517a92c Compare May 4, 2022 21:20
@jamesdaniels jamesdaniels mentioned this pull request May 5, 2022
Merged
@sam-gc sam-gc force-pushed the sam-gc/on-abort branch from a6b0d2c to 955f2dc Compare May 5, 2022 20:38
@sam-gc sam-gc merged commit d29a4fa into auth-middleware May 5, 2022
@sam-gc sam-gc deleted the sam-gc/on-abort branch May 5, 2022 20:38
@firebase firebase locked and limited conversation to collaborators Jun 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@yuchenshi yuchenshi yuchenshi approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi

@lisajian lisajian Awaiting requested review from lisajian

@allspain allspain Awaiting requested review from allspain

Assignees

@hsubox76 hsubox76

@yuchenshi yuchenshi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sam-gc @google-oss-bot @hsubox76 @yuchenshi @jamesdaniels