Skip to content

Update babel and changeset packages. #6147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 15, 2022
Merged

Update babel and changeset packages. #6147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b1b9460
Update babel package dependencies.
dwyfrequency Apr 13, 2022
8800426
Update changesets packages.
dwyfrequency Apr 13, 2022
5c4ffad
Merge remote-tracking branch 'origin/master' into changeSets
dwyfrequency Apr 14, 2022
cad31ac
Update babel-loader and plugin
dwyfrequency Apr 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,14 +62,14 @@
"repo-scripts/*"
],
"devDependencies": {
"@babel/core": "7.16.0",
"@babel/plugin-transform-modules-commonjs": "7.16.0",
"@babel/preset-env": "7.16.0",
"@babel/register": "7.16.0",
"@babel/preset-typescript": "7.16.0",
"babel-plugin-transform-import-meta": "2.1.0",
"@changesets/changelog-github": "0.4.1",
"@changesets/cli": "2.17.0",
"@babel/core": "7.17.9",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the babel updates be here? I noticed they're also in a separate PR: #6146

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was creating a chain of PRs until I hit a failure with the dependencies. I was then going to change the description to be inclusive of all of the successful dependency changes. If you would prefer, I'll create them all separate.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean that the @changesets bumps don't work without the @babel bumps?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I mean that I was just adding each dependency back one by one. If there were no failures, the last PR would include all of the dependency updates. @changesets is working with @babel

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was largely just a way that I could work on multiple dependency updates while waiting for the prior ones' tests to run.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, as long as it's working, I think it's ok to do PRs in any grouping, but I don't think there should be overlap between PRs, so I think either combine this with #6146 into one PR, or remove the @babel upgrades from this PR so it doesn't overlap with #6146.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closed #6146 and updated title & description to include @babel and @changesets updates

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's 2 deps in #6146 that aren't in this one:

  • "babel-plugin-transform-import-meta": "2.1.1",
  • "babel-loader": "8.2.4",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Updated those deps

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good now

"@babel/plugin-transform-modules-commonjs": "7.17.9",
"@babel/preset-env": "7.16.11",
"@babel/register": "7.17.7",
"@babel/preset-typescript": "7.16.7",
"babel-plugin-transform-import-meta": "2.1.1",
"@changesets/changelog-github": "0.4.4",
"@changesets/cli": "2.22.0",
"@types/chai": "4.2.22",
"@types/chai-as-promised": "7.1.4",
"@types/child-process-promise": "2.2.2",
Expand All @@ -92,7 +92,7 @@
"@typescript-eslint/parser": "4.31.2",
"api-documenter-me": "0.1.1",
"api-extractor-me": "0.1.2",
"babel-loader": "8.2.2",
"babel-loader": "8.2.4",
"chai": "4.3.4",
"chai-as-promised": "7.1.1",
"chalk": "4.1.2",
Expand Down
Loading