Skip to content

Update babel and changeset packages. #6147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 15, 2022
Merged

Update babel and changeset packages. #6147

merged 4 commits into from
Apr 15, 2022

Conversation

dwyfrequency
Copy link
Contributor

@dwyfrequency dwyfrequency commented Apr 13, 2022 •
edited
Loading

Updating babel and changeset packages as mentioned in pull request 5566 for all non-major dependencies.

@changeset-bot
Copy link

changeset-bot bot commented Apr 13, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: cad31ac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 13, 2022 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (95c59fe) and merge commit (a75eddf).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/npOugW0Mnw.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 13, 2022 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (95c59fe) and merge commit (a75eddf).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Clz93yQsNe.html

hsubox76
hsubox76 previously approved these changes Apr 14, 2022
View reviewed changes
@hsubox76 hsubox76 dismissed their stale review April 14, 2022 16:55

babel packages

hsubox76
hsubox76 reviewed Apr 14, 2022
View reviewed changes
package.json
"@babel/preset-env": "7.16.0",
"@babel/register": "7.16.0",
"@babel/preset-typescript": "7.16.0",
"@babel/core": "7.17.9",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the babel updates be here? I noticed they're also in a separate PR: #6146

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was creating a chain of PRs until I hit a failure with the dependencies. I was then going to change the description to be inclusive of all of the successful dependency changes. If you would prefer, I'll create them all separate.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean that the @changesets bumps don't work without the @babel bumps?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I mean that I was just adding each dependency back one by one. If there were no failures, the last PR would include all of the dependency updates. @changesets is working with @babel

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was largely just a way that I could work on multiple dependency updates while waiting for the prior ones' tests to run.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, as long as it's working, I think it's ok to do PRs in any grouping, but I don't think there should be overlap between PRs, so I think either combine this with #6146 into one PR, or remove the @babel upgrades from this PR so it doesn't overlap with #6146.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closed #6146 and updated title & description to include @babel and @changesets updates

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's 2 deps in #6146 that aren't in this one:

  • "babel-plugin-transform-import-meta": "2.1.1",
  • "babel-loader": "8.2.4",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Updated those deps

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good now

@dwyfrequency dwyfrequency changed the title Update changeset package. Update babel and changeset packages. Apr 14, 2022
@dwyfrequency dwyfrequency merged commit 5249483 into master Apr 15, 2022
@dwyfrequency dwyfrequency deleted the changeSets branch April 15, 2022 16:38
@firebase firebase locked and limited conversation to collaborators May 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@allspain allspain Awaiting requested review from allspain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dwyfrequency @google-oss-bot @hsubox76