Skip to content

Use RemoteDocumentCache.getAll() #5986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 10, 2022
Merged

Use RemoteDocumentCache.getAll() #5986

merged 2 commits into from
Feb 10, 2022

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Feb 9, 2022 •
edited by dconeybe
Loading

Port of firebase/firebase-android-sdk#3201, which also includes the rationale behind this change.

@changeset-bot
Copy link

changeset-bot bot commented Feb 9, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: ffb8f6f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2022 •
edited
Loading

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 9, 2022 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (434d87e)Merge (c321c7e)Diff
    browser233 kB233 kB-462 B (-0.2%)
    esm5291 kB290 kB-558 B (-0.2%)
    main463 kB462 kB-922 B (-0.2%)
    module233 kB233 kB-462 B (-0.2%)
    react-native233 kB233 kB-462 B (-0.2%)

  • bundle

    TypeBase (434d87e)Merge (c321c7e)Diff
    firestore (Persistence)234 kB234 kB-462 B (-0.2%)
    firestore (Query Cursors)190 kB190 kB-412 B (-0.2%)
    firestore (Query)191 kB191 kB-412 B (-0.2%)
    firestore (Read data once)180 kB179 kB-412 B (-0.2%)
    firestore (Realtime updates)182 kB181 kB-412 B (-0.2%)
    firestore (Transaction)164 kB164 kB-389 B (-0.2%)
    firestore (Write data)163 kB163 kB-389 B (-0.2%)

  • firebase

    TypeBase (434d87e)Merge (c321c7e)Diff
    firebase-compat.js758 kB757 kB-458 B (-0.1%)
    firebase-firestore-compat.js285 kB285 kB-458 B (-0.2%)
    firebase-firestore.js784 kB783 kB-595 B (-0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/c5XkGVvsge.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 9, 2022 •
edited
Loading

Size Analysis Report 1

This report is too large (66,825 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Q3waZ1Hctc.html

@schmidt-sebastian schmidt-sebastian merged commit 3fe2c4a into master Feb 10, 2022
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/getall branch February 10, 2022 18:57
@firebase firebase locked and limited conversation to collaborators Mar 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dconeybe dconeybe dconeybe approved these changes

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @google-oss-bot @dconeybe