Optimize query execution by deferring query evaluation #3201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with Head commit (39959e7d) is created by Prow via merging commits: 1986969 c72063d. |
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (39959e7d) is created by Prow via merging commits: 1986969 c72063d. |
dconeybe
requested changes
Dec 3, 2021
firebase-firestore/src/test/java/com/google/firebase/firestore/local/CountingQueryEngine.java
Outdated
Show resolved
Hide resolved
firebase-firestore/src/test/java/com/google/firebase/firestore/local/CountingQueryEngine.java
Outdated
Show resolved
Hide resolved
firebase-firestore/src/main/java/com/google/firebase/firestore/local/RemoteDocumentCache.java
Outdated
Show resolved
Hide resolved
firebase-firestore/src/main/java/com/google/firebase/firestore/local/RemoteDocumentCache.java
Outdated
Show resolved
Hide resolved
...e-firestore/src/main/java/com/google/firebase/firestore/local/SQLiteRemoteDocumentCache.java
Outdated
Show resolved
Hide resolved
dconeybe
approved these changes
Dec 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current query pipeline is essentially as such:
I think the idea behind this was that the RemoteDocumentCache uses the Query to filter the document it reads, but this code now lives in IndexManager. This PR therefore removes the "Query" functionality from the RemoteDocumentCache and instead just returns all documents from the collection.