fix interface AuthError #5609
Merged
fix interface AuthError #5609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change interface AuthError to correct structure
PabloLION
requested review from
avolkovi,
lisajian,
sam-gc and
yuchenshi
as code owners
|
sam-gc
requested changes
Oct 13, 2021
|
I'm not going to bother running the workflow on this since we know it's failing in it's current form. @Pablion one small change then we can merge this. Thanks again! |
sam-gc
approved these changes
Oct 14, 2021
sam-gc
added a commit
that referenced
this pull request
Oct 19, 2021
…urrent API standard (#5616) * fix interface AuthError (#5609) * fix interface AuthError change interface AuthError to correct structure * remove `declare` * Refactor MFA error to properly follow the new format * Add changeset * Add doc comment to MultiFactorError.customData * Apply suggestions from code review Co-authored-by: Kevin Cheung <[email protected]> * Update changeset to patch Co-authored-by: Pablion <[email protected]> Co-authored-by: Kevin Cheung <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend interface
FirebaseErrortoAuthErrorwith correct customDataChange tenantid to tenantId, other tenantId are formatted like this, better than smallcase since ID is a "word"
Discussion
moved from #5600
this closes #5599
More TODOs
Testing
I don't know how to test for this specific issue.
API Changes
NONE