Fix AuthError incoherent structure.

[PabloLION]

Add a AuthErrorData interface for customData in FirebaseError
Change tenantid to tenantId, other tenantId are formatted like this, better than smallcase since ID is a "word"

Discussion

this closes #5599

More TODOs

• Update this offical document page

Testing

I don't know how to test for this specific issue.

API Changes

NONE

[changeset-bot]

⚠️ No Changeset found

Latest commit: a17629f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[google-cla]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[PabloLION]

@googlebot I signed it!

[sam-gc]

Thanks for sending this! The PR looks good, but instead of creating a new named interface for error.customData, we'd like to have that field type inlined

[PabloLION]

Hi, @sam-gc
I made a new commit but in this way I cannot assert with extends Record<string, string | undefined>.(I don't know why I wanted this before, seems useless).
I read some stack overflow and official document, and now reckon that it is not possible, is it?
I'd be more than grateful if you could correct me.

---- update
For me, the extends is does the same job like & in a different context. But writing oldAuthErrorData & Record<string, string | undefined> seems meaningless to me.

[sam-gc]

Please run yarn build in the packages/auth directory -- I believe there will be a generated file change that will change that needs to be checked in as well

[sam-gc]

@Pablion I'm not sure I quite follow the issue you're describing, but if it builds and tests pass then this is what we want

[PabloLION]

I see what's going on here, we have an

export declare interface MultiFactorError extends AuthError {}

So all the related MultiFactorError are changed. I will do yarn test later, and try to fix this.

[sam-gc]

Okay so I dug into this a bit more and it looks like there's going to have to be a deep-ish refactor of the multi-factor code to make this work. @Pablion would you please change the base to https://github.com/firebase/firebase-js-sdk/tree/auth_error_type_fix ? We can go ahead and merge the type changes that you've done in this PR, and after that I'll go ahead and make the necessary refactors/fixes before opening a new PR to merge into Master. I'll CC you on that final PR 👍

[PabloLION]

@sam-gc I tried to fix the MFA error last night and found it quite complex. I'll do what you said now.

[sam-gc]

@Pablion I believe you can use this same PR, you just need to edit the base by clicking the edit button at top-right. If that doesn't work though, no big deal you can open a new PR

[PabloLION]

@sam-gc I closed this PR because I want to change the branch name, also thinking a new PR would make things clearer.