Remove ConnectionPool #5469
Merged
Remove ConnectionPool #5469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
requested review from
Feiyang1,
hiranya911 and
hsubox76
as code owners
|
Changeset File Check ✅
|
…s-sdk into mrschmidt/connection
egilmorez
approved these changes
Sep 13, 2021
| @@ -22,6 +22,9 @@ import { | |||
| } from '../../implementation/connection'; | |||
| import { internalError } from '../../implementation/error'; | |||
|
|
|||
| /** An override for the text-based Connection. Used in tests. */ | |||
There was a problem hiding this comment.
Should Connection be backticked as a literal? Looks like there are other instances of the same in other files in this PR.
There was a problem hiding this comment.
This is part of the internal code so I have no strong opinion, other than laziness :)
Binary Size ReportAffected SDKs
Test Logs |
Size Analysis ReportAffected Products
|
schmidt-sebastian
force-pushed
the
mrschmidt/connection
branch
from
3fc7c4e to
187ef92
Compare
schmidt-sebastian
force-pushed
the
mrschmidt/connection
branch
from
92f9e50 to
93001ef
Compare
hsubox76
approved these changes
Oct 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to reduce the diff for #4973
The PR removes the old ConnectionPool, which was never used to share connections but rather just allowed tests to inject a different connection type. Since #4973 introduces multiple connection types (string, blob, stream) and since we only want to include the connection types that are actually used, this PR now directly specifies the specific connection factory at the callsite (which for now is just a text-based connection).