Skip to content

Commit a531a7d

Browse files
Merge branch 'master' into mrschmidt/connection
2 parents cc120f7 + f485276 commit a531a7d

File tree

3 files changed

+8
-1
lines changed

3 files changed

+8
-1
lines changed

.changeset/dry-toes-hammer.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
"@firebase/auth-compat": minor
3-
"@firebase/auth": minor,
3+
"@firebase/auth": minor
44
"firebase": minor
55
---
66

.changeset/spotty-bags-double.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@firebase/firestore": patch
3+
---
4+
5+
Add missing compat Firestore conversion for runTransaction

packages/firestore/src/api/transaction.ts

+2
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import { Transaction as InternalTransaction } from '../core/transaction';
2020
import { DocumentReference } from '../lite-api/reference';
2121
import { Transaction as LiteTransaction } from '../lite-api/transaction';
2222
import { validateReference } from '../lite-api/write_batch';
23+
import { cast } from '../util/input_validation';
2324

2425
import { ensureFirestoreConfigured, Firestore } from './database';
2526
import { ExpUserDataWriter } from './reference_impl';
@@ -93,6 +94,7 @@ export function runTransaction<T>(
9394
firestore: Firestore,
9495
updateFunction: (transaction: Transaction) => Promise<T>
9596
): Promise<T> {
97+
firestore = cast(firestore, Firestore);
9698
const client = ensureFirestoreConfigured(firestore);
9799
return firestoreClientTransaction(client, internalTransaction =>
98100
updateFunction(new Transaction(firestore, internalTransaction))

0 commit comments

Comments
 (0)