Skip to content

[Auth] Add custom error factory for custom messages; add special handling for instanceof checks #5427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 7, 2021
Merged

[Auth] Add custom error factory for custom messages; add special handling for instanceof checks #5427

merged 2 commits into from
Sep 7, 2021

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Sep 1, 2021

Fixes #5420

We now provide better messaging in cases where auth is imported from multiple entry points, leading to mismatched types. Also small update for #5423; we now incorporate the message onto the error itself (as it should have been originally, thanks @lisajian for pointing that out)

@sam-gc sam-gc requested review from lisajian and yuchenshi September 1, 2021 21:54
@sam-gc sam-gc requested a review from avolkovi as a code owner September 1, 2021 21:54
@changeset-bot
Copy link

changeset-bot bot commented Sep 1, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 719aa95

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2021 •
edited
Loading

Changeset File Check ⚠️

  • Changeset formatting error in following file: 
    Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.
If this change doesn't need a release, run `changeset add --empty`.

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

No changes between base commit (08ec55d) and head commit (c6d7895).

lisajian
lisajian approved these changes Sep 1, 2021
View reviewed changes
@yuchenshi yuchenshi removed their assignment Sep 1, 2021
@sam-gc
Copy link
Contributor Author

sam-gc commented Sep 3, 2021

@yuchenshi I still need your review since Lisa's not yet a CODEOWNER

@sam-gc sam-gc requested a review from egilmorez as a code owner September 3, 2021 18:54
@sam-gc sam-gc merged commit 10c7b49 into master Sep 7, 2021
@sam-gc sam-gc deleted the sam-gc/errors branch September 7, 2021 15:21
@firebase firebase locked and limited conversation to collaborators Oct 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lisajian lisajian lisajian approved these changes

@yuchenshi yuchenshi yuchenshi approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi

@egilmorez egilmorez Awaiting requested review from egilmorez

Assignees

@lisajian lisajian

@yuchenshi yuchenshi

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@sam-gc @google-oss-bot @lisajian @yuchenshi