Skip to content

[Auth] Pass through server error messages to the error object when available #5423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 1, 2021

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Aug 31, 2021

Fixes #5386

In keeping with the new error format, the message is in error.customData.message instead of error.message.

@changeset-bot
Copy link

changeset-bot bot commented Aug 31, 2021

🦋 Changeset detected

Latest commit: d44e170

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/auth Patch
@firebase/auth-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2021

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

@sam-gc sam-gc requested a review from egilmorez as a code owner August 31, 2021 22:53
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 31, 2021

Size Analysis Report

Affected Products

No changes between base commit (bc3b405) and head commit (1bf8625).

Copy link
Contributor

@lisajian lisajian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do we need to update the example in https://cloud.google.com/identity-platform/docs/blocking-functions#blocking_registration_or_sign-in since the error is in customData? I think the only bit that needs to be updated is error.message.indexOf('Cloud Function') !== -1 should be error.customData.message.indexOf('Cloud Function') !== -1

@sam-gc
Copy link
Contributor Author

sam-gc commented Sep 1, 2021

In this case we shouldn't update the Cloud Identity Platform docs since the v9 SDK remains in beta for the Cloud Identity Platform features. We will need to update the compatibility layer to put the fields on the error instead of error.customData, but that's a larger PR that I'll do a bit later

@sam-gc sam-gc merged commit 08ec55d into master Sep 1, 2021
@sam-gc sam-gc deleted the sam-gc/server-message branch September 1, 2021 20:46
@google-oss-bot google-oss-bot mentioned this pull request Sep 7, 2021
@firebase firebase locked and limited conversation to collaborators Oct 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v9/auth] Blocking Function Errors in JS SDK do not provide full error message/info from blocking function
4 participants