Skip to content

Add isSupported() to firebase/messaging/sw exports #5313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2021
Merged

Conversation

hsubox76
Copy link
Contributor

Ensures that isSupported() function exported by @firebase/messaging/sw (#4665) is available from firebase/messaging/sw.

Fixes #5309

@changeset-bot
Copy link

changeset-bot bot commented Aug 17, 2021

⚠️ No Changeset found

Latest commit: 5988639

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

Changeset File Check ⚠️

  • Changeset formatting error in following file:
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.8" vs "file:../../packages-exp/firebase-exp"
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.8" vs "file:../../packages-exp/firebase-exp"
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.8" vs "file:../../packages-exp/firebase-exp"
    Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.
    If this change doesn't need a release, run `changeset add --empty`.
    

@hsubox76 hsubox76 added this to the v9 GA milestone Aug 17, 2021
@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (f825b1d) and head commit (217bf0d).

Test Logs

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

No changes between base commit (f825b1d) and head commit (217bf0d).

@Feiyang1 Feiyang1 assigned hsubox76 and unassigned Feiyang1 Aug 18, 2021
@hsubox76 hsubox76 merged commit f35b4e3 into master Aug 18, 2021
@hsubox76 hsubox76 deleted the ch-messaging-is branch August 18, 2021 21:43
schmidt-sebastian pushed a commit that referenced this pull request Aug 20, 2021
@firebase firebase locked and limited conversation to collaborators Sep 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The isSupported function is not exported from the Cloud messaging module for service worker in modular V9 SDK
3 participants