-
Notifications
You must be signed in to change notification settings - Fork 937
Add async isSupported
to Modular FM SDK
#4665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
isSupported
to Modular FM SDK
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
2 similar comments
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
Deprecating #4446 in favor of this PR
Instead of calling `isSupported` in `index.ts` and `index.sw.ts` (Problematic because devs will get error before they can do anything about it). The correct behavior should be: dev check env by calling isSupported; if they dont call and env not supported, then SDK throw error during messaging intialization stage
Deprecating #4446 in favor of this PR
279de76
to
4bf341d
Compare
This reverts commit 4bf341d.
This PR does 2 things
isSupported
fromindex.ts
andindex.sw.ts
(API Approved: go/js-messaging-is-supported)isWindowSupported
andisSwSupported
checks in its own context (window
andsw
respectively)Deprecating #4446 in favor of this PR