Skip to content

[Deprecated] Separate window/sw API checks #4446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

zwu52
Copy link
Member

@zwu52 zwu52 commented Feb 9, 2021

Also renames the checkers to make it more readable (since we no longer reference window and sw flows as controllers)

@zwu52 zwu52 requested review from Feiyang1 and hsubox76 February 9, 2021 23:10
@zwu52 zwu52 requested a review from hiranya911 as a code owner February 9, 2021 23:10
@changeset-bot
Copy link

changeset-bot bot commented Feb 9, 2021

⚠️ No Changeset found

Latest commit: 5d3b4cf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (05614aa) and head commit (7adc950).

Test Logs

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

  • @firebase/messaging-exp

    • deleteToken

      Size Table

      TypeBase (05614aa)Head (7adc950)Diff
      size
      7.51 kB
      7.19 kB
      -320 B (-4.3%)
      size-with-ext-deps
      24.2 kB
      23.8 kB
      -324 B (-1.3%)

      Dependency Table

      TypeBase (05614aa)Head (7adc950)Diff
      functions

      20 dependencies

      arrayToBase64
      checkTokenDetails
      dbGet
      dbRemove
      dbSet
      deleteToken
      deleteTokenInternal
      extractAppConfig
      getDbPromise
      getEndpoint
      getHeaders
      getKey
      getMissingValueError
      isSWControllerSupported
      isSupported
      isWindowControllerSupported
      migrateOldDatabase
      registerDefaultSw
      registerMessaging
      requestDeleteToken
      

      18 dependencies

      arrayToBase64
      checkTokenDetails
      dbGet
      dbRemove
      dbSet
      deleteToken
      deleteTokenInternal
      extractAppConfig
      getDbPromise
      getEndpoint
      getHeaders
      getKey
      getMissingValueError
      isWindowSupported
      migrateOldDatabase
      registerDefaultSw
      registerMessaging
      requestDeleteToken
      

      + isWindowSupported
      - isSWControllerSupported
      - isSupported
      - isWindowControllerSupported

    • getMessaging

      Size Table

      TypeBase (05614aa)Head (7adc950)Diff
      size
      3.67 kB
      3.35 kB
      -320 B (-8.7%)
      size-with-ext-deps
      20.2 kB
      19.9 kB
      -324 B (-1.6%)

      Dependency Table

      TypeBase (05614aa)Head (7adc950)Diff
      functions

      extractAppConfig
      getMessaging
      getMissingValueError
      isSWControllerSupported
      isSupported
      isWindowControllerSupported
      registerMessaging
      

      extractAppConfig
      getMessaging
      getMissingValueError
      isWindowSupported
      registerMessaging
      

      + isWindowSupported
      - isSWControllerSupported
      - isSupported
      - isWindowControllerSupported

    • getToken

      Size Table

      TypeBase (05614aa)Head (7adc950)Diff
      size
      12.0 kB
      11.7 kB
      -325 B (-2.7%)
      size-with-ext-deps
      28.7 kB
      28.4 kB
      -324 B (-1.1%)

      Dependency Table

      TypeBase (05614aa)Head (7adc950)Diff
      functions

      39 dependencies

      arrayToBase64
      base64ToArray
      checkTokenDetails
      dbGet
      dbRemove
      dbSet
      deleteTokenInternal
      externalizePayload
      extractAppConfig
      getBody
      getDbPromise
      getEndpoint
      getEventType
      getHeaders
      getKey
      getMissingValueError
      getNewToken
      getPushSubscription
      getToken
      getTokenInternal
      isConsoleMessage
      isSWControllerSupported
      isSupported
      isTokenValid
      isWindowControllerSupported
      logToScion
      messageEventListener
      migrateOldDatabase
      propagateDataPayload
      propagateFcmOptions
      propagateNotificationPayload
      registerDefaultSw
      registerMessaging
      requestDeleteToken
      requestGetToken
      requestUpdateToken
      updateSwReg
      updateToken
      updateVapidKey
      

      37 dependencies

      arrayToBase64
      base64ToArray
      checkTokenDetails
      dbGet
      dbRemove
      dbSet
      deleteTokenInternal
      externalizePayload
      extractAppConfig
      getBody
      getDbPromise
      getEndpoint
      getEventType
      getHeaders
      getKey
      getMissingValueError
      getNewToken
      getPushSubscription
      getToken
      getTokenInternal
      isConsoleMessage
      isTokenValid
      isWindowSupported
      logToScion
      messageEventListener
      migrateOldDatabase
      propagateDataPayload
      propagateFcmOptions
      propagateNotificationPayload
      registerDefaultSw
      registerMessaging
      requestDeleteToken
      requestGetToken
      requestUpdateToken
      updateSwReg
      updateToken
      updateVapidKey
      

      + isWindowSupported
      - isSWControllerSupported
      - isSupported
      - isWindowControllerSupported

    • onMessage

      Size Table

      TypeBase (05614aa)Head (7adc950)Diff
      size
      5.19 kB
      4.87 kB
      -320 B (-6.2%)
      size-with-ext-deps
      21.8 kB
      21.5 kB
      -324 B (-1.5%)

      Dependency Table

      TypeBase (05614aa)Head (7adc950)Diff
      functions

      15 dependencies

      externalizePayload
      extractAppConfig
      getEventType
      getMissingValueError
      isConsoleMessage
      isSWControllerSupported
      isSupported
      isWindowControllerSupported
      logToScion
      messageEventListener
      onMessage
      propagateDataPayload
      propagateFcmOptions
      propagateNotificationPayload
      registerMessaging
      

      13 dependencies

      externalizePayload
      extractAppConfig
      getEventType
      getMissingValueError
      isConsoleMessage
      isWindowSupported
      logToScion
      messageEventListener
      onMessage
      propagateDataPayload
      propagateFcmOptions
      propagateNotificationPayload
      registerMessaging
      

      + isWindowSupported
      - isSWControllerSupported
      - isSupported
      - isWindowControllerSupported

@Feiyang1
Copy link
Member

Feiyang1 commented Mar 2, 2021

Seems messaging-exp is failing build.

zwu52 added a commit that referenced this pull request Mar 22, 2021
Deprecating #4446 in favor of this PR
@zwu52 zwu52 marked this pull request as draft March 22, 2021 15:39
@zwu52 zwu52 changed the title Separate window/sw API checks [Deprecated] Separate window/sw API checks Mar 24, 2021
zwu52 added a commit that referenced this pull request Apr 2, 2021
Deprecating #4446 in favor of this PR
zwu52 added a commit that referenced this pull request Apr 5, 2021
Deprecating #4446 in favor of this PR
zwu52 added a commit that referenced this pull request Apr 5, 2021
Deprecating #4446 in favor of this PR
zwu52 added a commit that referenced this pull request Apr 5, 2021
Deprecating #4446 in favor of this PR
zwu52 added a commit that referenced this pull request Apr 5, 2021
Deprecating #4446 in favor of this PR
@zwu52 zwu52 closed this May 18, 2021
@firebase firebase locked and limited conversation to collaborators Jun 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants