Skip to content

Add storage to Node bundle and Node docs #5215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 30, 2021
Merged

Add storage to Node bundle and Node docs #5215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f574db3
Add storage to Node bundle and Node docs
hsubox76 Jul 29, 2021
1991ffb
Update API reports
hsubox76 Jul 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 4 additions & 18 deletions common/api-review/analytics-exp.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,6 @@ export interface EventParams {
// (undocumented)
checkout_step?: number;
// (undocumented)
content_id?: string;
// (undocumented)
content_type?: string;
// (undocumented)
coupon?: string;
Expand All @@ -77,6 +75,8 @@ export interface EventParams {
firebase_screen?: string;
firebase_screen_class?: string;
// (undocumented)
item_id?: string;
// (undocumented)
item_list_id?: string;
// (undocumented)
item_list_name?: string;
Expand Down Expand Up @@ -125,18 +125,12 @@ export interface GtagConfigParams {
// (undocumented)
[key: string]: unknown;
'allow_ad_personalization_signals'?: boolean;
'anonymize_ip'?: boolean;
'cookie_domain'?: string;
'cookie_expires'?: number;
'cookie_flags'?: string;
'cookie_prefix'?: string;
'cookie_update'?: boolean;
'custom_map'?: {
[key: string]: unknown;
};
'link_attribution'?: boolean;
'page_location'?: string;
'page_path'?: string;
'page_title'?: string;
'send_page_view'?: boolean;
}
Expand Down Expand Up @@ -262,7 +256,6 @@ export function logEvent(analyticsInstance: Analytics, eventName: 'exception', e
export function logEvent(analyticsInstance: Analytics, eventName: 'generate_lead', eventParams?: {
value?: EventParams['value'];
currency?: EventParams['currency'];
transaction_id?: EventParams['transaction_id'];
[key: string]: any;
}, options?: AnalyticsCallOptions): void;

Expand Down Expand Up @@ -295,13 +288,8 @@ export function logEvent(analyticsInstance: Analytics, eventName: 'purchase' | '

// @public
export function logEvent(analyticsInstance: Analytics, eventName: 'screen_view', eventParams?: {
app_name: string;
screen_name: EventParams['screen_name'];
firebase_screen: EventParams['firebase_screen'];
firebase_screen_class: EventParams['firebase_screen_class'];
app_id?: string;
app_version?: string;
app_installer_id?: string;
[key: string]: any;
}, options?: AnalyticsCallOptions): void;

Expand All @@ -313,10 +301,8 @@ export function logEvent(analyticsInstance: Analytics, eventName: 'search' | 'vi

// @public
export function logEvent(analyticsInstance: Analytics, eventName: 'select_content', eventParams?: {
items?: EventParams['items'];
promotions?: EventParams['promotions'];
content_type?: EventParams['content_type'];
content_id?: EventParams['content_id'];
item_id?: EventParams['item_id'];
[key: string]: any;
}, options?: AnalyticsCallOptions): void;

Expand Down Expand Up @@ -347,7 +333,7 @@ export function logEvent(analyticsInstance: Analytics, eventName: 'set_checkout_
export function logEvent(analyticsInstance: Analytics, eventName: 'share', eventParams?: {
method?: EventParams['method'];
content_type?: EventParams['content_type'];
content_id?: EventParams['content_id'];
item_id?: EventParams['item_id'];
[key: string]: any;
}, options?: AnalyticsCallOptions): void;

Expand Down
3 changes: 0 additions & 3 deletions packages-exp/firebase-exp/compat/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7451,9 +7451,6 @@ declare namespace firebase.messaging {
function isSupported(): boolean;
}

/**
* @webonly
*/
declare namespace firebase.storage {
/**
* The full set of object metadata, including read-only properties.
Expand Down
1 change: 1 addition & 0 deletions packages-exp/firebase-exp/compat/index.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import './auth';
import './database';
import './firestore';
import './functions';
import './storage';

firebase.registerVersion(name, version, 'compat-node');

Expand Down
3 changes: 0 additions & 3 deletions packages/firebase/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7499,9 +7499,6 @@ declare namespace firebase.messaging {
function isSupported(): boolean;
}

/**
* @webonly
*/
declare namespace firebase.storage {
/**
* The full set of object metadata, including read-only properties.
Expand Down
1 change: 1 addition & 0 deletions packages/firebase/src/index.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import '../database';
import '../firestore';
import '../firestore/bundle';
import '../functions';
import '../storage';

firebase.registerVersion(name, version, 'node');

Expand Down