Skip to content

Add storage to Node bundle and Node docs #5215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 30, 2021
Merged

Add storage to Node bundle and Node docs #5215

merged 2 commits into from
Jul 30, 2021

Conversation

hsubox76
Copy link
Contributor

We support Node in Storage for both v9 and v8 now (#5149 and #4985) so it should be included in Node docs (remove @webonly tags) and in the Node all-in-one bundle.

@changeset-bot
Copy link

changeset-bot bot commented Jul 29, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1991ffb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

Changeset File Check ⚠️

  • Changeset formatting error in following file: 
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.7" vs "file:../../packages-exp/firebase-exp"
Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.7" vs "file:../../packages-exp/firebase-exp"
Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.7" vs "file:../../packages-exp/firebase-exp"
Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.
If this change doesn't need a release, run `changeset add --empty`.

@Feiyang1
Copy link
Member

Need a changeset for the index.node.ts change

@Feiyang1 Feiyang1 assigned hsubox76 and unassigned Feiyang1 Jul 29, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 29, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

No changes between base commit (bd50d83) and head commit (a9b122f).

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 29, 2021 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (bd50d83) and head commit (2e29422).

@hsubox76 hsubox76 merged commit ca4ead2 into master Jul 30, 2021
@hsubox76 hsubox76 deleted the ch-storage-add branch July 30, 2021 03:48
@firebase firebase locked and limited conversation to collaborators Aug 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@egilmorez egilmorez Awaiting requested review from egilmorez

@hiranya911 hiranya911 Awaiting requested review from hiranya911

Assignees

@hsubox76 hsubox76

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsubox76 @Feiyang1 @google-oss-bot