Skip to content

Port 3P token API to app-check-exp #5069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 30, 2021
Merged

Port 3P token API to app-check-exp #5069

merged 5 commits into from
Jun 30, 2021

Conversation

hsubox76
Copy link
Contributor

Porting 3P token APIs that were added to v8 (non-modular) API in #5033

Also added some test reliability improvements.

@changeset-bot
Copy link

changeset-bot bot commented Jun 24, 2021

⚠️ No Changeset found

Latest commit: 43c5c6d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (3ea1e1f) and head commit (544dbf0).

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 24, 2021

Size Analysis Report

Affected Products

Diffs between base commit (1e6bd3e) and head commit (7cb510b) are too large (243,158 characters) to display.

Please check below links to see details from the original test log.

@hsubox76 hsubox76 force-pushed the ch-appcheckexp-update branch from 70bc0ff to dfbe67c Compare June 28, 2021 17:46
Comment on lines 294 to 297
} else {
// Otherwise return the token, whether or not it has an error field.
observer.next(token);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not correct for 3p listeners - If there is no error handler, the error should just be ignored.

Do we handle both 2p and 3p listeners in this function? If so, they need to be handled differently, where 2p listeners always get the token regardless of the error state, and 3p listeners get a real token in the success handler, and errors in error handler and errors should be ignored if there is no error handler.

That also means we need a way to tell 2p and 3p listeners apart.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probably missed it in the PR for v8, but we need to do the same in v8 too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a type property to the observers. Let me know if it works, and if the names are ok.

@Feiyang1 Feiyang1 assigned hsubox76 and unassigned Feiyang1 Jun 29, 2021
@hsubox76 hsubox76 assigned Feiyang1 and unassigned hsubox76 Jun 30, 2021
@github-actions
Copy link
Contributor

Changeset File Check ⚠️

  • Changeset formatting error in following file:
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.5" vs "file:../../packages-exp/firebase-exp"
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.5" vs "file:../../packages-exp/firebase-exp"
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.5" vs "file:../../packages-exp/firebase-exp"
    Error: Failed to find where HEAD diverged from master. Does master exist?
        at async getChangedFilesSince (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/git/dist/git.cjs.dev.js:169:22)
        at async Object.getChangedPackagesSinceRef (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/git/dist/git.cjs.dev.js:208:24)
        at async getStatus (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/cli/dist/cli.cjs.dev.js:977:27)
        at async run$1 (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/cli/dist/cli.cjs.dev.js:1227:11)
    

@hsubox76 hsubox76 requested a review from egilmorez as a code owner June 30, 2021 21:25
@hsubox76 hsubox76 merged commit 580b354 into master Jun 30, 2021
@hsubox76 hsubox76 deleted the ch-appcheckexp-update branch June 30, 2021 21:46
@firebase firebase locked and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants