Add app-check-compat #5073
Add app-check-compat #5073
Conversation
|
Changeset File Check ✅
|
| }); | ||
|
|
||
| it( | ||
| 'activate("string") calls modular initializeAppCheck() with a ' + |
There was a problem hiding this comment.
Are we changing v8 to the provider pattern?
There was a problem hiding this comment.
Not sure when we should do this. It's needed for reCAPTCHA Enterprise. Probably this change should be made along with an App Check milestone (GA, reCAPTCHA Enterprise, or other big feature), so people won't be caught off guard by the breaking change?
There was a problem hiding this comment.
I think it depends on if v9 goes GA before or after adding reCaptcha enterprise support. If former, we don't need to update app-check-compat since we will only add new features to the modular API. If latter, we would need to align with the milestones and update the compat package.
| getToken: () => Promise.resolve({} as AppCheckToken) | ||
| }); | ||
| expect(initializeAppCheckStub).to.be.calledWith(app, { | ||
| provider: match.instanceOf(CustomProvider), |
There was a problem hiding this comment.
Should check the customProvider has the same getToken() supplied to activate()
Add app-check-compat layer. This is based on the ch-appcheckexp-update branch because it needs the 2P token methods added to exp first.
@egilmorez You can ignore this one, you were automatically added because there was a change to the
.changesetdirectory, but it was just the config file, not a changelog note.