Skip to content

Add getAuth() default arg to all entry points #5064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2021
Merged

Conversation

hsubox76
Copy link
Contributor

getAuth() is implemented separately in each auth entry point file. #4702 added a default app param value in only the browser index.ts entry point. Adding to the other entry points for consistency.

Fixes #4949

@changeset-bot
Copy link

changeset-bot bot commented Jun 23, 2021

⚠️ No Changeset found

Latest commit: c6fd598

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (d9dc89f) and head commit (24ff1a3).

Test Logs

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

No changes between base commit (d9dc89f) and head commit (24ff1a3).

@hsubox76 hsubox76 requested a review from Feiyang1 June 23, 2021 22:22
@hsubox76 hsubox76 merged commit 36f0c20 into master Jun 24, 2021
@hsubox76 hsubox76 deleted the ch-auth-default-app branch June 24, 2021 17:53
@firebase firebase locked and limited conversation to collaborators Jul 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read property 'container' of undefined Angular Universal
4 participants