Skip to content

Support default app in the modular SDK #4702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 6, 2021
Merged

Support default app in the modular SDK #4702

merged 2 commits into from
Apr 6, 2021

Conversation

Feiyang1
Copy link
Member

Make app optional in getFoo() functions.
Implements the proposal

@changeset-bot
Copy link

changeset-bot bot commented Mar 31, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: c10f03c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Feiyang1
Copy link
Member Author

@davideast @samtstern FYI

hsubox76
hsubox76 approved these changes Apr 1, 2021
View reviewed changes
Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending resolution of merge conflicts.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2021 •
edited
Loading

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

  • @firebase/analytics-exp

    • getAnalytics

      Size Table

      TypeBase (9f5578e)Head (48b375d)Diff
      size
      9.08 kB
      9.10 kB
      +18 B (+0.2%)
      size-with-ext-deps
      26.7 kB
      27.4 kB
      +632 B (+2.4%)

      External Dependency Table

      ModuleBase (9f5578e)Head (48b375d)Diff
      @firebase/app-exp

      _getProvider
_registerComponent
registerVersion


      _getProvider
_registerComponent
getApp
registerVersion


      + getApp

  • @firebase/auth-exp

    • getAuth

      Size Table

      TypeBase (9f5578e)Head (48b375d)Diff
      size
      55.3 kB
      55.3 kB
      +22 B (+0.0%)
      size-with-ext-deps
      66.3 kB
      66.9 kB
      +629 B (+0.9%)

      External Dependency Table

      ModuleBase (9f5578e)Head (48b375d)Diff
      @firebase/app-exp

      SDK_VERSION
_getProvider
_registerComponent
registerVersion


      SDK_VERSION
_getProvider
_registerComponent
getApp
registerVersion


      + getApp

  • @firebase/functions-exp

    • getFunctions

      Size Table

      TypeBase (9f5578e)Head (48b375d)Diff
      size
      2.05 kB
      2.07 kB
      +16 B (+0.8%)
      size-with-ext-deps
      6.31 kB
      7.54 kB
      +1.24 kB (+19.6%)

      External Dependency Table

      ModuleBase (9f5578e)Head (48b375d)Diff
      @firebase/app-exp

      _getProvider
_registerComponent
registerVersion


      _getProvider
_registerComponent
getApp
registerVersion


      + getApp

  • @firebase/installations-exp

    • getInstallations

      Size Table

      TypeBase (9f5578e)Head (48b375d)Diff
      size
      8.48 kB
      8.49 kB
      +18 B (+0.2%)
      size-with-ext-deps
      17.1 kB
      17.8 kB
      +651 B (+3.8%)

      External Dependency Table

      ModuleBase (9f5578e)Head (48b375d)Diff
      @firebase/app-exp

      _getProvider
_registerComponent
registerVersion


      _getProvider
_registerComponent
getApp
registerVersion


      + getApp

  • @firebase/messaging-exp

    • getMessaging

      Size Table

      TypeBase (9f5578e)Head (48b375d)Diff
      size
      3.70 kB
      3.71 kB
      +16 B (+0.4%)
      size-with-ext-deps
      20.6 kB
      21.2 kB
      +648 B (+3.2%)

      External Dependency Table

      ModuleBase (9f5578e)Head (48b375d)Diff
      @firebase/app-exp

      _getProvider
_registerComponent


      _getProvider
_registerComponent
getApp


      + getApp

  • @firebase/performance-exp

    • getPerformance

      Size Table

      TypeBase (9f5578e)Head (48b375d)Diff
      size
      17.4 kB
      17.4 kB
      +18 B (+0.1%)
      size-with-ext-deps
      34.7 kB
      35.4 kB
      +640 B (+1.8%)

      External Dependency Table

      ModuleBase (9f5578e)Head (48b375d)Diff
      @firebase/app-exp

      _getProvider
_registerComponent
registerVersion


      _getProvider
_registerComponent
getApp
registerVersion


      + getApp

  • @firebase/remote-config-exp

    • getRemoteConfig

      Size Table

      TypeBase (9f5578e)Head (48b375d)Diff
      size
      10.2 kB
      10.2 kB
      +16 B (+0.2%)
      size-with-ext-deps
      27.2 kB
      27.8 kB
      +631 B (+2.3%)

      External Dependency Table

      ModuleBase (9f5578e)Head (48b375d)Diff
      @firebase/app-exp

      SDK_VERSION
_getProvider
_registerComponent
registerVersion


      SDK_VERSION
_getProvider
_registerComponent
getApp
registerVersion


      + getApp

@Feiyang1 Feiyang1 merged commit 318d9bf into master Apr 6, 2021
@Feiyang1 Feiyang1 deleted the fei-default-app branch April 6, 2021 21:40
@firebase firebase locked and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@jsdt jsdt Awaiting requested review from jsdt

@sam-gc sam-gc Awaiting requested review from sam-gc

@schmidt-sebastian schmidt-sebastian Awaiting requested review from schmidt-sebastian

@yuchenshi yuchenshi Awaiting requested review from yuchenshi

Assignees

@hsubox76 hsubox76

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Feiyang1 @google-oss-bot @hsubox76