Skip to content

Fix messaging delete bug #4995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 8, 2021
Merged

Fix messaging delete bug #4995

merged 2 commits into from
Jun 8, 2021

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Jun 8, 2021

deleteService() wasn't populated with a value so when _delete() tries to call it, there's an error. I think this pattern was copied from functions-exp where the constructor assigns a value to deleteService(). But it never gets assigned here, so just inlining the Promise.resolve().

@changeset-bot
Copy link

changeset-bot bot commented Jun 8, 2021

⚠️ No Changeset found

Latest commit: 1218b5d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (645e166) and head commit (622ee8e).

Test Logs

@Feiyang1 Feiyang1 assigned hsubox76 and unassigned Feiyang1 Jun 8, 2021
@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

  • @firebase/messaging-exp

    • deleteToken

      Size Table

      TypeBase (645e166)Head (622ee8e)Diff
      size
      8.93 kB
      8.93 kB
      -3 B (-0.0%)
      size-with-ext-deps
      26.7 kB
      26.7 kB
      -3 B (-0.0%)
    • getMessaging

      Size Table

      TypeBase (645e166)Head (622ee8e)Diff
      size
      5.09 kB
      5.09 kB
      -3 B (-0.1%)
      size-with-ext-deps
      23.4 kB
      23.4 kB
      -3 B (-0.0%)
    • getToken

      Size Table

      TypeBase (645e166)Head (622ee8e)Diff
      size
      12.0 kB
      12.0 kB
      -3 B (-0.0%)
      size-with-ext-deps
      29.8 kB
      29.8 kB
      -3 B (-0.0%)
    • isSupported

      Size Table

      TypeBase (645e166)Head (622ee8e)Diff
      size
      4.98 kB
      4.97 kB
      -3 B (-0.1%)
      size-with-ext-deps
      22.6 kB
      22.6 kB
      -3 B (-0.0%)
    • onMessage

      Size Table

      TypeBase (645e166)Head (622ee8e)Diff
      size
      5.17 kB
      5.16 kB
      -3 B (-0.1%)
      size-with-ext-deps
      22.8 kB
      22.8 kB
      -3 B (-0.0%)

@hsubox76 hsubox76 merged commit ed4f95c into master Jun 8, 2021
@hsubox76 hsubox76 deleted the ch-delete-fix branch June 8, 2021 19:19
@firebase firebase locked and limited conversation to collaborators Jul 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants