Fix messaging delete bug (#4995)

hsubox76 · web-flow · commit ed4f95ceef98 · 2021-06-08T12:19:24.000-07:00
diff --git a/packages-exp/messaging-exp/src/messaging-service.ts b/packages-exp/messaging-exp/src/messaging-service.ts
@@ -27,7 +27,6 @@ import { extractAppConfig } from './helpers/extract-app-config';
 export class MessagingService implements _FirebaseService {
   readonly app!: FirebaseApp;
   readonly firebaseDependencies!: FirebaseInternalDependencies;
-  deleteService!: () => Promise<void>;
 
   swRegistration?: ServiceWorkerRegistration;
   vapidKey?: string;
@@ -58,6 +57,6 @@ export class MessagingService implements _FirebaseService {
   }
 
   _delete(): Promise<void> {
-    return this.deleteService();
+    return Promise.resolve();
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,6 @@ import { extractAppConfig } from './helpers/extract-app-config';`
`27`	`27`	`export class MessagingService implements _FirebaseService {`
`28`	`28`	`readonly app!: FirebaseApp;`
`29`	`29`	`readonly firebaseDependencies!: FirebaseInternalDependencies;`
`30`		`- deleteService!: () => Promise<void>;`
`31`	`30`
`32`	`31`	`swRegistration?: ServiceWorkerRegistration;`
`33`	`32`	`vapidKey?: string;`
`@@ -58,6 +57,6 @@ export class MessagingService implements _FirebaseService {`
`58`	`57`	`}`
`59`	`58`
`60`	`59`	`_delete(): Promise<void> {`
`61`		`- return this.deleteService();`
	`60`	`+ return Promise.resolve();`
`62`	`61`	`}`
`63`	`62`	`}`