create rollup typings for messaging #4974
Conversation
|
Size Analysis Report |
| "api-report": "api-extractor run --local --verbose", | ||
| "type-check": "tsc --noEmit" | ||
| "api-report": "yarn api-report:rollup && yarn api-report:api-json", | ||
| "api-report:rollup": "TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\"}' ts-node ../../repo-scripts/prune-dts/extract-public-api.ts --package messaging-exp --packageRoot . --typescriptDts ./dist/index.d.ts --rollupDts ./dist/private.d.ts --untrimmedRollupDts ./dist/internal.d.ts --publicDts ./dist/index-public.d.ts", |
There was a problem hiding this comment.
Just out of curiosity, when do we use ts-node and ts-node-script?
There was a problem hiding this comment.
ts-node-script reads the tsconfig from the source directory where the script lives, while ts-node loads tsconfig from the cwd. This behavior has changed in v10 where ts-node behaves the same way as ts-node-script by default. (we haven't updated to v10 yet)
In most cases, you'd want to use ts-node-script because you want to use the tsconfig of the script.
Here, we should really use ts-node-script, but it won't matter once we upgrade to v10, so I will keep it as is for now.
There was a problem hiding this comment.
Well, ended up updating to ts-node-script
We need rollup typings to generate overloads for interop in messaging-compat.