Skip to content

Commit f41d11b

Browse files
authored
create rollup typings for messaging (#4974)
* create rollup typings for messaging * update * update string
1 parent cf636ae commit f41d11b

File tree

3 files changed

+17
-7
lines changed

3 files changed

+17
-7
lines changed

packages-exp/messaging-compat/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
"test:karma": "karma start --single-run",
2626
"test:debug": "karma start --browsers=Chrome --auto-watch",
2727
"type-check": "tsc --noEmit",
28-
"add-compat-overloads": "ts-node-script ../../scripts/exp/create-overloads.ts -i ../messaging-exp/dist/messaging-exp-public.d.ts -o dist/src/index.d.ts -a -r FirebaseMessaging:MessagingCompat -r FirebaseApp:FirebaseAppCompat --moduleToEnhance @firebase/messaging"
28+
"add-compat-overloads": "ts-node-script ../../scripts/exp/create-overloads.ts -i ../messaging-exp/dist/index-public.d.ts -o dist/src/index.d.ts -a -r FirebaseMessaging:MessagingCompat -r FirebaseApp:FirebaseAppCompat --moduleToEnhance @firebase/messaging"
2929
},
3030
"peerDependencies": {
3131
"@firebase/app-compat": "0.x"

packages-exp/messaging-exp/api-extractor.json

+9-2
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,15 @@
88
}],
99
"dtsRollup": {
1010
/**
11-
* rollup is not supported when multiple entry points are present
11+
* rollup is not supported when multiple entry points are present.
12+
* npm script api-report:rollup is used to generate dts rollup.
1213
*/
1314
"enabled": false
14-
}
15+
},
16+
"apiReport": {
17+
/**
18+
* apiReport is handled by npm script api-report:rollup
19+
*/
20+
"enabled": false
21+
}
1522
}

packages-exp/messaging-exp/package.json

+7-4
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,18 @@
1818
"lint:fix": "eslint --fix -c .eslintrc.js '**/*.ts' --ignore-path '../../.gitignore'",
1919
"build": "rollup -c && yarn api-report",
2020
"build:deps": "lerna run --scope @firebase/'{app-exp,messaging-exp}' --include-dependencies build",
21-
"build:release": "rollup -c rollup.config.release.js && yarn api-report",
21+
"build:release": "rollup -c rollup.config.release.js && yarn api-report && yarn typings:public",
2222
"dev": "rollup -c -w",
2323
"test": "run-p test:karma type-check lint ",
2424
"test:integration": "run-p test:karma type-check lint && cd ../../integration/messaging && npm run-script test",
2525
"test:ci": "node ../../scripts/run_tests_in_ci.js",
2626
"test:karma": "karma start --single-run",
2727
"test:debug": "karma start --browsers=Chrome --auto-watch",
28-
"api-report": "api-extractor run --local --verbose",
29-
"type-check": "tsc --noEmit"
28+
"api-report": "yarn api-report:rollup && yarn api-report:api-json",
29+
"api-report:rollup": "ts-node-script ../../repo-scripts/prune-dts/extract-public-api.ts --package messaging-exp --packageRoot . --typescriptDts ./dist/index.d.ts --rollupDts ./dist/private.d.ts --untrimmedRollupDts ./dist/internal.d.ts --publicDts ./dist/index-public.d.ts",
30+
"api-report:api-json": "api-extractor run --local --verbose",
31+
"type-check": "tsc --noEmit",
32+
"typings:public": "node ../../scripts/exp/use_typings.js ./dist/index-public.d.ts"
3033
},
3134
"license": "Apache-2.0",
3235
"peerDependencies": {
@@ -54,4 +57,4 @@
5457
"url": "https://github.com/firebase/firebase-js-sdk/issues"
5558
},
5659
"esm5": "dist/index.esm.js"
57-
}
60+
}

0 commit comments

Comments
 (0)