Skip to content

Fix indexDB putObject concurrency issue and cache. #4710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 2, 2021
Merged

Fix indexDB putObject concurrency issue and cache. #4710

merged 2 commits into from
Apr 2, 2021

Conversation

yuchenshi
Copy link
Member

WANT_LGTM=all

@yuchenshi yuchenshi requested review from avolkovi and sam-gc April 1, 2021 22:33
@changeset-bot
Copy link

changeset-bot bot commented Apr 1, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3150340

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

avolkovi
avolkovi reviewed Apr 1, 2021
View reviewed changes
sam-gc
sam-gc approved these changes Apr 2, 2021
View reviewed changes
Copy link
Contributor

@sam-gc sam-gc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good pending tests passing

@yuchenshi yuchenshi force-pushed the ys/fix-persistence-concurrency-cache branch from 46452c9 to cb1a4dd Compare April 2, 2021 17:52
@yuchenshi yuchenshi force-pushed the ys/fix-persistence-concurrency-cache branch from cb1a4dd to 3150340 Compare April 2, 2021 18:05
@yuchenshi yuchenshi merged commit 358cc4c into master Apr 2, 2021
@yuchenshi yuchenshi deleted the ys/fix-persistence-concurrency-cache branch April 2, 2021 19:00
@firebase firebase locked and limited conversation to collaborators May 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@avolkovi avolkovi avolkovi approved these changes

@sam-gc sam-gc sam-gc approved these changes

Assignees

@avolkovi avolkovi

@sam-gc sam-gc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuchenshi @avolkovi @sam-gc