Fix indexDB putObject concurrency issue and cache.

Author: yuchenshi

packages-exp/auth-exp/src/platform_browser/persistence/indexed_db.ts

@@ -127,20 +127,11 @@ export async function _putObject(
   key: string,
   value: PersistenceValue | string
 ): Promise<void> {
-  const getRequest = getObjectStore(db, false).get(key);
-  const data = await new DBPromise<DBObject | null>(getRequest).toPromise();
-  if (data) {
-    // Force an index signature on the user object
-    data.value = value as PersistedBlob;
-    const request = getObjectStore(db, true).put(data);
-    return new DBPromise<void>(request).toPromise();
-  } else {
-    const request = getObjectStore(db, true).add({
-      [DB_DATA_KEYPATH]: key,
-      value
-    });
-    return new DBPromise<void>(request).toPromise();
-  }
+  const request = getObjectStore(db, true).put({
+    [DB_DATA_KEYPATH]: key,
+    value
+  });
+  return new DBPromise<void>(request).toPromise();
 }
 
 async function getObject(
@@ -395,9 +386,6 @@ class IndexedDBLocalPersistence implements InternalPersistence {
     key: string,
     newValue: PersistenceValue | null
   ): void {
-    if (!this.listeners[key]) {
-      return;
-    }
     this.localCache[key] = newValue;
     for (const listener of Array.from(this.listeners[key])) {
       listener(newValue);
@@ -434,7 +422,6 @@ class IndexedDBLocalPersistence implements InternalPersistence {
 
       if (this.listeners[key].size === 0) {
         delete this.listeners[key];
-        delete this.localCache[key];
       }
     }
 

packages-exp/auth-exp/src/platform_browser/persistence/local_storage.ts

@@ -165,9 +165,6 @@ class BrowserLocalPersistence
   }
 
   private notifyListeners(key: string, value: string | null): void {
-    if (!this.listeners[key]) {
-      return;
-    }
     this.localCache[key] = value;
     for (const listener of Array.from(this.listeners[key])) {
       listener(value ? JSON.parse(value) : value);
@@ -209,7 +206,6 @@ class BrowserLocalPersistence
   }
 
   _addListener(key: string, listener: StorageEventListener): void {
-    this.localCache[key] = this.storage.getItem(key);
     if (Object.keys(this.listeners).length === 0) {
       // Whether browser can detect storage event when it had already been pushed to the background.
       // This may happen in some mobile browsers. A localStorage change in the foreground window
@@ -231,7 +227,6 @@ class BrowserLocalPersistence
 
       if (this.listeners[key].size === 0) {
         delete this.listeners[key];
-        delete this.localCache[key];
       }
     }