-
Notifications
You must be signed in to change notification settings - Fork 943
[Auth] Add popup WebDriver tests (duplicated from the redirect tests) #4602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
284 changes: 284 additions & 0 deletions
284
packages-exp/auth-exp/test/integration/webdriver/popup.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,284 @@ | ||
/** | ||
* @license | ||
* Copyright 2021 Google LLC | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
import { | ||
OperationType, | ||
UserCredential, | ||
User, | ||
OAuthCredential | ||
// eslint-disable-next-line import/no-extraneous-dependencies | ||
} from '@firebase/auth-exp'; | ||
import { expect, use } from 'chai'; | ||
import { IdPPage } from './util/idp_page'; | ||
import * as chaiAsPromised from 'chai-as-promised'; | ||
import { browserDescribe } from './util/test_runner'; | ||
import { AnonFunction, CoreFunction, PopupFunction } from './util/functions'; | ||
|
||
use(chaiAsPromised); | ||
|
||
browserDescribe('Popup IdP tests', driver => { | ||
it('allows users to sign in', async () => { | ||
await driver.callNoWait(PopupFunction.IDP_POPUP); | ||
await driver.selectPopupWindow(); | ||
const widget = new IdPPage(driver.webDriver); | ||
|
||
// We're now on the widget page; wait for load | ||
await widget.pageLoad(); | ||
await widget.clickAddAccount(); | ||
await widget.fillEmail('[email protected]'); | ||
await widget.fillDisplayName('Bob Test'); | ||
await widget.fillScreenName('bob.test'); | ||
await widget.fillProfilePhoto('http://bob.test/bob.png'); | ||
await widget.clickSignIn(); | ||
|
||
await driver.selectMainWindow(); | ||
const result: UserCredential = await driver.call( | ||
PopupFunction.POPUP_RESULT | ||
); | ||
const currentUser = await driver.getUserSnapshot(); | ||
expect(currentUser.email).to.eq('[email protected]'); | ||
expect(currentUser.displayName).to.eq('Bob Test'); | ||
expect(currentUser.photoURL).to.eq('http://bob.test/bob.png'); | ||
|
||
expect(result.operationType).to.eq(OperationType.SIGN_IN); | ||
expect(result.user).to.eql(currentUser); | ||
}); | ||
|
||
it('can link with another account account', async () => { | ||
// First, sign in anonymously | ||
const { user: anonUser }: UserCredential = await driver.call( | ||
AnonFunction.SIGN_IN_ANONYMOUSLY | ||
); | ||
|
||
// Then, link with popup | ||
await driver.callNoWait(PopupFunction.IDP_LINK_POPUP); | ||
await driver.selectPopupWindow(); | ||
const widget = new IdPPage(driver.webDriver); | ||
await widget.pageLoad(); | ||
await widget.clickAddAccount(); | ||
await widget.fillEmail('[email protected]'); | ||
await widget.clickSignIn(); | ||
|
||
await driver.selectMainWindow(); | ||
// Back on main page; check for the current user matching the anonymous | ||
// account as well as the new IdP account | ||
const user: User = await driver.getUserSnapshot(); | ||
expect(user.uid).to.eq(anonUser.uid); | ||
expect(user.email).to.eq('[email protected]'); | ||
}); | ||
|
||
it('can be converted to a credential', async () => { | ||
// Start with popup | ||
await driver.callNoWait(PopupFunction.IDP_POPUP); | ||
await driver.selectPopupWindow(); | ||
const widget = new IdPPage(driver.webDriver); | ||
await widget.pageLoad(); | ||
await widget.clickAddAccount(); | ||
await widget.fillEmail('[email protected]'); | ||
await widget.clickSignIn(); | ||
|
||
// Generate a credential, then store it on the window before logging out | ||
await driver.selectMainWindow(); | ||
const first = await driver.getUserSnapshot(); | ||
const cred: OAuthCredential = await driver.call( | ||
PopupFunction.GENERATE_CREDENTIAL_FROM_RESULT | ||
); | ||
expect(cred.accessToken).to.be.a('string'); | ||
expect(cred.idToken).to.be.a('string'); | ||
expect(cred.signInMethod).to.eq('google.com'); | ||
|
||
// We've now generated that credential. Sign out and sign back in using it | ||
await driver.call(CoreFunction.SIGN_OUT); | ||
const { user: second }: UserCredential = await driver.call( | ||
PopupFunction.SIGN_IN_WITH_POPUP_CREDENTIAL | ||
); | ||
expect(second.uid).to.eq(first.uid); | ||
expect(second.providerData).to.eql(first.providerData); | ||
}); | ||
|
||
it('handles account exists different credential errors', async () => { | ||
// Start with popup and a verified account | ||
await driver.callNoWait(PopupFunction.IDP_POPUP); | ||
await driver.selectPopupWindow(); | ||
const widget = new IdPPage(driver.webDriver); | ||
await widget.pageLoad(); | ||
await widget.clickAddAccount(); | ||
await widget.fillEmail('[email protected]'); | ||
await widget.clickSignIn(); | ||
|
||
await driver.selectMainWindow(); | ||
const original = await driver.getUserSnapshot(); | ||
expect(original.emailVerified).to.be.true; | ||
|
||
// Try to sign in with an unverified Facebook account | ||
// TODO: Convert this to the widget once unverified accounts work | ||
// Come back and verify error / prepare for link | ||
await expect( | ||
driver.call(PopupFunction.TRY_TO_SIGN_IN_UNVERIFIED, '[email protected]') | ||
).to.be.rejected.and.eventually.have.property( | ||
'code', | ||
'auth/account-exists-with-different-credential' | ||
); | ||
|
||
// Now do the link | ||
await driver.call(PopupFunction.LINK_WITH_ERROR_CREDENTIAL); | ||
|
||
// Check the user for both providers | ||
const user = await driver.getUserSnapshot(); | ||
expect(user.uid).to.eq(original.uid); | ||
expect(user.providerData.map(d => d.providerId)).to.have.members([ | ||
'google.com', | ||
'facebook.com' | ||
]); | ||
}); | ||
|
||
context('with existing user', () => { | ||
let user1: User; | ||
let user2: User; | ||
|
||
beforeEach(async () => { | ||
// Create a couple existing users | ||
let cred: UserCredential = await driver.call( | ||
PopupFunction.CREATE_FAKE_GOOGLE_USER, | ||
'[email protected]' | ||
); | ||
user1 = cred.user; | ||
cred = await driver.call( | ||
PopupFunction.CREATE_FAKE_GOOGLE_USER, | ||
'[email protected]' | ||
); | ||
user2 = cred.user; | ||
await driver.call(CoreFunction.SIGN_OUT); | ||
}); | ||
|
||
it('a user can sign in again', async () => { | ||
// Sign in using pre-poulated user | ||
await driver.callNoWait(PopupFunction.IDP_POPUP); | ||
await driver.selectPopupWindow(); | ||
|
||
// This time, select an existing account | ||
const widget = new IdPPage(driver.webDriver); | ||
await widget.pageLoad(); | ||
await widget.selectExistingAccountByEmail(user1.email!); | ||
|
||
// Double check the new sign in matches the old | ||
await driver.selectMainWindow(); | ||
const user = await driver.getUserSnapshot(); | ||
expect(user.uid).to.eq(user1.uid); | ||
expect(user.email).to.eq(user1.email); | ||
}); | ||
|
||
it('reauthenticate works for the correct user', async () => { | ||
// Sign in using pre-poulated user | ||
await driver.callNoWait(PopupFunction.IDP_POPUP); | ||
await driver.selectPopupWindow(); | ||
|
||
const widget = new IdPPage(driver.webDriver); | ||
await widget.pageLoad(); | ||
await widget.selectExistingAccountByEmail(user1.email!); | ||
|
||
// Double check the new sign in matches the old | ||
await driver.selectMainWindow(); | ||
let user = await driver.getUserSnapshot(); | ||
expect(user.uid).to.eq(user1.uid); | ||
expect(user.email).to.eq(user1.email); | ||
|
||
// Reauthenticate specifically | ||
await driver.callNoWait(PopupFunction.IDP_REAUTH_POPUP); | ||
await driver.selectPopupWindow(); | ||
await widget.pageLoad(); | ||
await widget.selectExistingAccountByEmail(user1.email!); | ||
|
||
await driver.selectMainWindow(); | ||
user = await driver.getUserSnapshot(); | ||
expect(user.uid).to.eq(user1.uid); | ||
expect(user.email).to.eq(user1.email); | ||
}); | ||
|
||
it('reauthenticate throws for wrong user', async () => { | ||
// Sign in using pre-poulated user | ||
await driver.callNoWait(PopupFunction.IDP_POPUP); | ||
await driver.selectPopupWindow(); | ||
|
||
const widget = new IdPPage(driver.webDriver); | ||
await widget.pageLoad(); | ||
await widget.selectExistingAccountByEmail(user1.email!); | ||
|
||
// Immediately reauth but with the wrong user | ||
await driver.selectMainWindow(); | ||
await driver.callNoWait(PopupFunction.IDP_REAUTH_POPUP); | ||
await driver.selectPopupWindow(); | ||
await widget.pageLoad(); | ||
await widget.selectExistingAccountByEmail(user2.email!); | ||
|
||
await driver.selectMainWindow(); | ||
await expect( | ||
driver.call(PopupFunction.POPUP_RESULT) | ||
).to.be.rejected.and.eventually.have.property( | ||
'code', | ||
'auth/user-mismatch' | ||
); | ||
}); | ||
|
||
it('handles aborted sign ins', async () => { | ||
await driver.callNoWait(PopupFunction.IDP_POPUP); | ||
await driver.selectPopupWindow(); | ||
const widget = new IdPPage(driver.webDriver); | ||
|
||
// Don't actually sign in; go back to the previous page | ||
await widget.pageLoad(); | ||
await driver.closePopup(); | ||
await expect( | ||
driver.call(PopupFunction.POPUP_RESULT) | ||
).to.be.rejected.and.eventually.have.property( | ||
'code', | ||
'auth/popup-closed-by-user' | ||
); | ||
expect(await driver.getUserSnapshot()).to.be.null; | ||
|
||
// Now do sign in | ||
await driver.callNoWait(PopupFunction.IDP_POPUP); | ||
await driver.selectPopupWindow(); | ||
// Use user1 | ||
await widget.pageLoad(); | ||
await widget.selectExistingAccountByEmail(user1.email!); | ||
|
||
// Ensure the user was signed in... | ||
await driver.selectMainWindow(); | ||
let user = await driver.getUserSnapshot(); | ||
expect(user.uid).to.eq(user1.uid); | ||
expect(user.email).to.eq(user1.email); | ||
|
||
// Now open another sign in, but return | ||
await driver.callNoWait(PopupFunction.IDP_REAUTH_POPUP); | ||
await driver.selectPopupWindow(); | ||
await widget.pageLoad(); | ||
await driver.closePopup(); | ||
await expect( | ||
driver.call(PopupFunction.POPUP_RESULT) | ||
).to.be.rejected.and.eventually.have.property( | ||
'code', | ||
'auth/popup-closed-by-user' | ||
); | ||
|
||
// Make sure state remained | ||
user = await driver.getUserSnapshot(); | ||
expect(user.uid).to.eq(user1.uid); | ||
expect(user.email).to.eq(user1.email); | ||
}).timeout(12_000); // Test takes a while due to the closed-by-user errors | ||
}); | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In
popup.js
andredirect.js
, I was previously assigning state to the window directly (things likeerrorCred
). I didn't want that to clash by using it in multiple files (it applies to both popup and redirect) so I started putting it on these objects (window.redirect.errorCred
andwindow.popup.errorCred
). That doesn't work though if you makewindow.popup
the imported module directly.