Skip to content

[Auth] Add popup WebDriver tests (duplicated from the redirect tests) #4602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 12, 2021

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Mar 9, 2021

No description provided.

@sam-gc sam-gc requested a review from yuchenshi March 9, 2021 17:36
@sam-gc sam-gc requested a review from avolkovi as a code owner March 9, 2021 17:36
@changeset-bot
Copy link

changeset-bot bot commented Mar 9, 2021

⚠️ No Changeset found

Latest commit: c5e0284

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 9, 2021

Binary Size Report

Affected SDKs

No changes between base commit (1de07ba) and head commit (ac94ca2).

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 9, 2021

Size Analysis Report

Affected Products

No changes between base commit (1de07ba) and head commit (ac94ca2).

Base automatically changed from samgho/further-redirect to master March 9, 2021 23:28
window.core = core;
window.anonymous = anonymous;
window.redirect = redirect;
window.core = { ...core };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In popup.js and redirect.js, I was previously assigning state to the window directly (things like errorCred). I didn't want that to clash by using it in multiple files (it applies to both popup and redirect) so I started putting it on these objects (window.redirect.errorCred and window.popup.errorCred). That doesn't work though if you make window.popup the imported module directly.

@sam-gc sam-gc merged commit 0ac48bb into master Mar 12, 2021
@sam-gc sam-gc deleted the samgho/popup branch March 12, 2021 17:28
@firebase firebase locked and limited conversation to collaborators Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants