-
Notifications
You must be signed in to change notification settings - Fork 938
[Auth] Add popup WebDriver tests (duplicated from the redirect tests) #4602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Size Analysis Report |
window.core = core; | ||
window.anonymous = anonymous; | ||
window.redirect = redirect; | ||
window.core = { ...core }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In popup.js
and redirect.js
, I was previously assigning state to the window directly (things like errorCred
). I didn't want that to clash by using it in multiple files (it applies to both popup and redirect) so I started putting it on these objects (window.redirect.errorCred
and window.popup.errorCred
). That doesn't work though if you make window.popup
the imported module directly.
No description provided.