Create messaging-compat #4544

zwu52 · 2021-02-26T05:08:57Z

Using the modular sdk to recreate legacy API surface

changeset-bot · 2021-02-26T05:08:59Z

⚠️ No Changeset found

Latest commit: d0476f0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2021-02-26T05:10:52Z

Changeset File Check ✅

No modified packages are missing from the changeset file.
No changeset formatting errors detected.

hsubox76

From the CI errors:

Needs an .eslintrc.js
Add @firebase/messaging-compat after this line:

firebase-js-sdk/.changeset/config.json

Line 25 in c3e5d5a

"@firebase/messaging-exp",

packages-exp/messaging-compat/karma.conf.js

packages-exp/messaging-compat/rollup.config.js

packages-exp/messaging-compat/rollup.config.release.js

packages-exp/messaging-compat/src/registerMessagingCompat.ts

packages-exp/messaging-compat/package.json

packages-exp/messaging-compat/README.md

packages-exp/messaging-compat/src/registerMessagingCompat.ts

google-oss-bot · 2021-03-08T20:06:12Z

Binary Size Report

Affected SDKs

`@firebase/app`

Type	Base (`5e7c013`)	Head (`fd45230`)	Diff
browser	10.8 kB	10.8 kB	+1 B (+0.0%)
esm2017	9.57 kB	9.57 kB	+1 B (+0.0%)
lite	8.88 kB	8.88 kB	+1 B (+0.0%)
lite-esm2017	7.87 kB	7.87 kB	+1 B (+0.0%)
main	9.93 kB	9.93 kB	+1 B (+0.0%)
module	10.8 kB	10.8 kB	+1 B (+0.0%)
react-native	9.64 kB	9.64 kB	+1 B (+0.0%)

@firebase/component

Type Base (5e7c013) Head (fd45230) Diff

browser 5.33 kB 5.37 kB +44 B (+0.8%)

main 5.63 kB 5.69 kB +57 B (+1.0%)

module 5.33 kB 5.37 kB +44 B (+0.8%)

`@firebase/database`

Type	Base (`5e7c013`)	Head (`fd45230`)	Diff
browser	274 kB	275 kB	+420 B (+0.2%)
esm2017	246 kB	248 kB	+2.25 kB (+0.9%)
main	277 kB	277 kB	+446 B (+0.2%)
module	274 kB	275 kB	+420 B (+0.2%)

`@firebase/database-exp`

Type	Base (`5e7c013`)	Head (`fd45230`)	Diff
browser	274 kB	272 kB	-2.63 kB (-1.0%)
esm2017	243 kB	245 kB	+2.16 kB (+0.9%)
main	276 kB	273 kB	-2.46 kB (-0.9%)
module	274 kB	272 kB	-2.63 kB (-1.0%)

`@firebase/firestore`

Type	Base (`5e7c013`)	Head (`fd45230`)	Diff
browser	259 kB	259 kB	+39 B (+0.0%)
esm2017	202 kB	202 kB	-12 B (-0.0%)
main	530 kB	530 kB	+68 B (+0.0%)
module	259 kB	259 kB	+39 B (+0.0%)
react-native	202 kB	202 kB	-12 B (-0.0%)

@firebase/firestore-exp

Type Base (5e7c013) Head (fd45230) Diff

browser 199 kB 199 kB -63 B (-0.0%)

main 505 kB 505 kB -63 B (-0.0%)

module 199 kB 199 kB -63 B (-0.0%)

react-native 200 kB 200 kB -63 B (-0.0%)

`@firebase/firestore-lite`

Type	Base (`5e7c013`)	Head (`fd45230`)	Diff
browser	64.9 kB	64.9 kB	+5 B (+0.0%)
main	143 kB	143 kB	-5 B (-0.0%)
module	64.9 kB	64.9 kB	+5 B (+0.0%)
react-native	65.1 kB	65.1 kB	+5 B (+0.0%)

`@firebase/firestore/bundle`

Type	Base (`5e7c013`)	Head (`fd45230`)	Diff
browser	266 kB	266 kB	+78 B (+0.0%)
esm2017	155 kB	155 kB	+27 B (+0.0%)
main	526 kB	526 kB	+69 B (+0.0%)
module	266 kB	266 kB	+78 B (+0.0%)
react-native	155 kB	155 kB	+27 B (+0.0%)

`@firebase/firestore/memory`

Type	Base (`5e7c013`)	Head (`fd45230`)	Diff
browser	196 kB	196 kB	-29 B (-0.0%)
esm2017	152 kB	152 kB	-12 B (-0.0%)
main	324 kB	324 kB	-12 B (-0.0%)
module	196 kB	196 kB	-29 B (-0.0%)
react-native	152 kB	152 kB	-12 B (-0.0%)

`@firebase/firestore/memory-bundle`

Type	Base (`5e7c013`)	Head (`fd45230`)	Diff
browser	205 kB	205 kB	+10 B (+0.0%)
esm2017	155 kB	155 kB	+27 B (+0.0%)
main	321 kB	321 kB	-12 B (-0.0%)
module	205 kB	205 kB	+10 B (+0.0%)
react-native	155 kB	155 kB	+27 B (+0.0%)

@firebase/installations

Type Base (5e7c013) Head (fd45230) Diff

main 22.2 kB 22.2 kB +22 B (+0.1%)

module 21.6 kB 21.6 kB +28 B (+0.1%)
@firebase/logger

Type Base (5e7c013) Head (fd45230) Diff

main 5.50 kB 5.38 kB -121 B (-2.2%)

module 4.83 kB 4.65 kB -179 B (-3.7%)
@firebase/messaging

Type Base (5e7c013) Head (fd45230) Diff

main 34.9 kB 34.9 kB +22 B (+0.1%)

module 34.4 kB 34.4 kB +28 B (+0.1%)
@firebase/performance

Type Base (5e7c013) Head (fd45230) Diff

browser 27.6 kB 27.7 kB +50 B (+0.2%)

main 28.0 kB 28.0 kB +69 B (+0.2%)

module 27.6 kB 27.7 kB +50 B (+0.2%)
@firebase/storage

Type Base (5e7c013) Head (fd45230) Diff

browser 60.2 kB 60.2 kB -3 B (-0.0%)

main 60.7 kB 60.7 kB -2 B (-0.0%)

module 60.2 kB 60.2 kB -3 B (-0.0%)

`@firebase/util`

Type	Base (`5e7c013`)	Head (`fd45230`)	Diff
browser	20.2 kB	20.5 kB	+285 B (+1.4%)
esm2017	19.0 kB	19.2 kB	+275 B (+1.4%)
main	24.4 kB	24.8 kB	+393 B (+1.6%)
module	20.2 kB	20.5 kB	+285 B (+1.4%)

`firebase`

Click to show 14 binary size changes.

Type	Base (`5e7c013`)	Head (`fd45230`)	Diff
firebase-analytics.js	35.7 kB	35.6 kB	-51 B (-0.1%)
firebase-app.js	19.9 kB	19.9 kB	-33 B (-0.2%)
firebase-database.js	184 kB	179 kB	-5.12 kB (-2.8%)
firebase-firestore.js	304 kB	303 kB	-109 B (-0.0%)
firebase-firestore.memory.js	243 kB	243 kB	-133 B (-0.1%)
firebase-functions.js	9.99 kB	10.1 kB	+142 B (+1.4%)
firebase-installations.js	19.0 kB	19.1 kB	+136 B (+0.7%)
firebase-messaging.js	40.7 kB	40.8 kB	+148 B (+0.4%)
firebase-performance-standalone.es2017.js	71.9 kB	71.9 kB	+2 B (+0.0%)
firebase-performance-standalone.js	48.0 kB	47.8 kB	-209 B (-0.4%)
firebase-performance.js	38.4 kB	38.2 kB	-221 B (-0.6%)
firebase-remote-config.js	36.8 kB	36.7 kB	-53 B (-0.1%)
firebase-storage.js	39.8 kB	39.8 kB	+40 B (+0.1%)
firebase.js	845 kB	839 kB	-5.20 kB (-0.6%)

Test Logs

Base (5e7c0130): https://github.com/firebase/firebase-js-sdk/actions/runs/601004952
Head (fd452300): https://github.com/firebase/firebase-js-sdk/actions/runs/633741042

google-oss-bot · 2021-03-08T20:09:45Z

Size Analysis Report

Affected Products

Diffs between base commit (6d6aa3e) and head commit (5b49379) are too large (470,788 characters) to display.

Please check below links to see details from the original test log.

Test Logs

Head (5b49379): https://github.com/firebase/firebase-js-sdk/actions/runs/658811791

packages-exp/messaging-compat/package.json

packages-exp/messaging-compat/src/messaging-compat.ts

packages-exp/messaging-compat/src/registerMessagingCompat.ts

hsubox76 · 2021-03-16T19:08:23Z

Approved pending CI

Using the modular sdk to recreate legacy API surface

- Update licenses date to 2020 (from 2017, 2018) - Declare Module in `registerMessagingCompat.ts` - Update build rule (package.json): -- add `app-comapt` as a dev dependency

Thanks Christina for the input here. Changes are - Add entry in changeset file - Add eslintrc.js to `messaging-compat`

- return type in `onMessage`

- Updated dependencies versions - Remove redundant namespace declarations

zwu52 requested review from Feiyang1, hiranya911 and hsubox76 as code owners February 26, 2021 05:08

hsubox76 requested changes Feb 26, 2021

View reviewed changes

Feiyang1 reviewed Feb 26, 2021

View reviewed changes

packages-exp/messaging-compat/README.md Outdated Show resolved Hide resolved

packages-exp/messaging-compat/src/registerMessagingCompat.ts Outdated Show resolved Hide resolved

Feiyang1 assigned zwu52 Feb 26, 2021

zwu52 requested review from hsubox76 and Feiyang1 March 8, 2021 19:46

zwu52 marked this pull request as draft March 11, 2021 21:41

Feiyang1 reviewed Mar 12, 2021

View reviewed changes

zwu52 requested a review from Feiyang1 March 15, 2021 17:33

zwu52 marked this pull request as ready for review March 15, 2021 17:33

Feiyang1 approved these changes Mar 16, 2021

View reviewed changes

hsubox76 force-pushed the create-messaging-compat branch from 3c6f07b to fc4f21d Compare March 16, 2021 18:59

hsubox76 approved these changes Mar 16, 2021

View reviewed changes

zwu52 added 6 commits March 16, 2021 12:59

Create messaging-compat

607a36b

Using the modular sdk to recreate legacy API surface

Modify based on review

f198087

- Update licenses date to 2020 (from 2017, 2018) - Declare Module in `registerMessagingCompat.ts` - Update build rule (package.json): -- add `app-comapt` as a dev dependency

Fix build based on Christina's input

50e8762

Thanks Christina for the input here. Changes are - Add entry in changeset file - Add eslintrc.js to `messaging-compat`

Resolve lint issue surfaced from test

f1c4099

- return type in `onMessage`

Add unit tests

a462a91

Improve based on Fei's comments/feedbacks

d0476f0

- Updated dependencies versions - Remove redundant namespace declarations

hsubox76 force-pushed the create-messaging-compat branch from fc4f21d to d0476f0 Compare March 16, 2021 19:59

zwu52 merged commit 3a465b4 into master Mar 16, 2021

zwu52 deleted the create-messaging-compat branch March 16, 2021 21:21

firebase locked and limited conversation to collaborators Apr 16, 2021

Create messaging-compat #4544

Create messaging-compat #4544

Uh oh!

Conversation

zwu52 commented Feb 26, 2021

Uh oh!

changeset-bot bot commented Feb 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

github-actions bot commented Feb 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changeset File Check ✅

Uh oh!

hsubox76 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

google-oss-bot commented Mar 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Binary Size Report

Affected SDKs

@firebase/app

@firebase/component

@firebase/database

@firebase/database-exp

@firebase/firestore

@firebase/firestore-exp

@firebase/firestore-lite

@firebase/firestore/bundle

@firebase/firestore/memory

@firebase/firestore/memory-bundle

@firebase/installations

@firebase/logger

@firebase/messaging

@firebase/performance

@firebase/storage

@firebase/util

firebase

Test Logs

Uh oh!

google-oss-bot commented Mar 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Analysis Report

Affected Products

Test Logs

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hsubox76 commented Mar 16, 2021

Uh oh!

Uh oh!

changeset-bot bot commented Feb 26, 2021 •

edited

Loading

github-actions bot commented Feb 26, 2021 •

edited

Loading

google-oss-bot commented Mar 8, 2021 •

edited

Loading

`@firebase/app`

`@firebase/component`

`@firebase/database`

`@firebase/database-exp`

`@firebase/firestore`

`@firebase/firestore-exp`

`@firebase/firestore-lite`

`@firebase/firestore/bundle`

`@firebase/firestore/memory`

`@firebase/firestore/memory-bundle`

`@firebase/installations`

`@firebase/logger`

`@firebase/messaging`

`@firebase/performance`

`@firebase/storage`

`@firebase/util`

`firebase`

google-oss-bot commented Mar 8, 2021 •

edited

Loading