Skip to content

Commit d0476f0

Browse files
zwu52hsubox76
authored andcommitted
Improve based on Fei's comments/feedbacks
- Updated dependencies versions - Remove redundant namespace declarations
1 parent a462a91 commit d0476f0

File tree

3 files changed

+5
-13
lines changed

3 files changed

+5
-13
lines changed

packages-exp/messaging-compat/package.json

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,18 +31,17 @@
3131
},
3232
"dependencies": {
3333
"@firebase/messaging-exp": "0.0.900",
34-
"@firebase/component": "0.2.0",
34+
"@firebase/component": "0.2.1",
3535
"@firebase/installations-exp": "0.0.900",
36-
"@firebase/util": "0.3.4",
37-
"idb": "3.0.2",
38-
"tslib": "^1.11.1"
36+
"@firebase/util": "0.4.0",
37+
"tslib": "^2.0.0"
3938
},
4039
"devDependencies": {
4140
"@firebase/app-compat": "0.0.900",
4241
"@rollup/plugin-json": "4.1.0",
4342
"rollup-plugin-typescript2": "0.29.0",
4443
"ts-essentials": "7.0.1",
45-
"typescript": "4.0.5"
44+
"typescript": "4.2.2"
4645
},
4746
"repository": {
4847
"directory": "packages/messaging",

packages-exp/messaging-compat/src/messaging-compat.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,6 @@ import { NextFn, Observer, Unsubscribe } from '@firebase/util';
3131
import { onBackgroundMessage } from '@firebase/messaging-exp/sw';
3232

3333
export class MessagingCompat implements _FirebaseService {
34-
readonly app!: AppCompat;
35-
readonly messaging!: FirebaseMessaging;
36-
3734
swRegistration?: ServiceWorkerRegistration;
3835
vapidKey?: string;
3936

@@ -47,7 +44,7 @@ export class MessagingCompat implements _FirebaseService {
4744
| Observer<MessagePayload>
4845
| null = null;
4946

50-
constructor(app: AppCompat, messaging: FirebaseMessaging) {
47+
constructor(readonly app: AppCompat, readonly messaging: FirebaseMessaging) {
5148
this.app = app;
5249
this.messaging = messaging;
5350
}

packages-exp/messaging-compat/src/registerMessagingCompat.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,16 +22,12 @@ import {
2222
InstanceFactory
2323
} from '@firebase/component';
2424

25-
import { FirebaseApp } from '@firebase/app-compat';
26-
import { FirebaseMessaging } from '@firebase/messaging-exp';
2725
import { MessagingCompat } from './messaging-compat';
2826
import { _registerComponent } from '@firebase/app-exp';
2927

3028
declare module '@firebase/component' {
3129
interface NameServiceMapping {
32-
'app-compat': FirebaseApp;
3330
'messaging-compat': MessagingCompat;
34-
'messaging-exp': FirebaseMessaging;
3531
}
3632
}
3733

0 commit comments

Comments
 (0)