Skip to content

Create compat package form performance exp #4522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 12, 2021
Merged

Create compat package form performance exp #4522

merged 6 commits into from
Mar 12, 2021

Conversation

alikn
Copy link
Contributor

@alikn alikn commented Feb 24, 2021

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2021 •
edited
Loading

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 24, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • @firebase/component

    Type Base (6b336dc) Head (567c7ec) Diff
    browser 5.37 kB 6.18 kB +812 B (+15.1%)
    esm2017 4.08 kB 4.77 kB +695 B (+17.1%)
    main 5.69 kB 6.50 kB +812 B (+14.3%)
    module 5.37 kB 6.18 kB +812 B (+15.1%)

  • @firebase/database

    Type Base (6b336dc) Head (567c7ec) Diff
    browser 275 kB 275 kB +29 B (+0.0%)
    esm2017 248 kB 248 kB +21 B (+0.0%)
    main 277 kB 277 kB +29 B (+0.0%)
    module 275 kB 275 kB +29 B (+0.0%)

  • @firebase/database-exp

    Type Base (6b336dc) Head (567c7ec) Diff
    browser 272 kB 272 kB +29 B (+0.0%)
    esm2017 245 kB 245 kB +21 B (+0.0%)
    main 273 kB 273 kB +29 B (+0.0%)
    module 272 kB 272 kB +29 B (+0.0%)

  • @firebase/firestore-exp

    Type Base (6b336dc) Head (567c7ec) Diff
    browser 199 kB 199 kB +25 B (+0.0%)
    main 505 kB 505 kB +43 B (+0.0%)
    module 199 kB 199 kB +25 B (+0.0%)
    react-native 200 kB 200 kB +25 B (+0.0%)

  • @firebase/firestore-lite

    Type Base (6b336dc) Head (567c7ec) Diff
    browser 64.9 kB 64.9 kB +25 B (+0.0%)
    main 143 kB 143 kB +43 B (+0.0%)
    module 64.9 kB 64.9 kB +25 B (+0.0%)
    react-native 65.1 kB 65.1 kB +25 B (+0.0%)

  • @firebase/functions

    Type Base (6b336dc) Head (567c7ec) Diff
    browser 9.87 kB 9.90 kB +29 B (+0.3%)
    esm2017 7.69 kB 7.71 kB +21 B (+0.3%)
    main 10.3 kB 10.3 kB +29 B (+0.3%)
    module 9.87 kB 9.90 kB +29 B (+0.3%)

  • @firebase/remote-config

    Type Base (6b336dc) Head (567c7ec) Diff
    browser 22.4 kB 22.4 kB +29 B (+0.1%)
    esm2017 17.4 kB 17.4 kB +21 B (+0.1%)
    main 22.9 kB 23.0 kB +29 B (+0.1%)
    module 22.4 kB 22.4 kB +29 B (+0.1%)

  • @firebase/storage

    Type Base (6b336dc) Head (567c7ec) Diff
    browser 60.2 kB 60.2 kB +29 B (+0.0%)
    esm2017 51.9 kB 51.9 kB +21 B (+0.0%)
    main 60.7 kB 60.7 kB +29 B (+0.0%)
    module 60.2 kB 60.2 kB +29 B (+0.0%)

  • @firebase/storage/exp

    Type Base (6b336dc) Head (567c7ec) Diff
    browser 49.2 kB 49.2 kB +21 B (+0.0%)
    main 50.0 kB 50.0 kB +21 B (+0.0%)
    module 49.2 kB 49.2 kB +21 B (+0.0%)

  • firebase

    Type Base (6b336dc) Head (567c7ec) Diff
    firebase-app.js 19.9 kB 20.4 kB +581 B (+2.9%)
    firebase-database.js 178 kB 179 kB +605 B (+0.3%)
    firebase-functions.js 10.1 kB 10.2 kB +23 B (+0.2%)
    firebase-performance-standalone.es2017.js 71.9 kB 72.3 kB +457 B (+0.6%)
    firebase-performance-standalone.js 47.8 kB 48.4 kB +581 B (+1.2%)
    firebase-remote-config.js 36.8 kB 36.8 kB +19 B (+0.1%)
    firebase-storage.js 39.8 kB 39.9 kB +23 B (+0.1%)
    firebase.js 839 kB 840 kB +671 B (+0.1%)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 24, 2021 •
edited
Loading

Size Analysis Report

Affected Products

Diffs between base commit (6b336dc) and head commit (567c7ec) are too large (198,650 characters) to display.

Please check below links to see details from the original test log.

Feiyang1
Feiyang1 reviewed Feb 25, 2021
View reviewed changes
hsubox76
hsubox76 reviewed Feb 25, 2021
View reviewed changes
Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix the changeset error, add @firebase/performance-compat after this line in this file:

firebase-js-sdk/.changeset/config.json

Line 27 in 89a4f64

"@firebase/performance-exp",

@changeset-bot
Copy link

changeset-bot bot commented Mar 12, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 07d234c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Feiyang1 Feiyang1 merged commit ef1a7d9 into master Mar 12, 2021
@Feiyang1 Feiyang1 deleted the perf-compat branch March 12, 2021 22:56
@firebase firebase locked and limited conversation to collaborators Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsubox76 hsubox76 hsubox76 left review comments

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@hiranya911 hiranya911 Awaiting requested review from hiranya911

Assignees

@alikn alikn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alikn @google-oss-bot @Feiyang1 @hsubox76