Skip to content

Commit 23e6201

Browse files
author
alikn
committed
update performance-compat package to remove performance-types-exp as a dependency
1 parent 5096fa1 commit 23e6201

File tree

4 files changed

+8
-13
lines changed

4 files changed

+8
-13
lines changed

packages-exp/performance-compat/package.json

+4-5
Original file line numberDiff line numberDiff line change
@@ -30,18 +30,17 @@
3030
},
3131
"dependencies": {
3232
"@firebase/performance-exp": "0.0.900",
33-
"@firebase/performance-types-exp": "0.0.900",
34-
"@firebase/util": "0.3.4",
33+
"@firebase/util": "0.4.0",
3534
"@firebase/logger": "0.2.6",
36-
"@firebase/component": "0.2.0",
37-
"tslib": "^1.11.1"
35+
"@firebase/component": "0.2.1",
36+
"tslib": "^2.0.0"
3837
},
3938
"devDependencies": {
4039
"rollup": "2.35.1",
4140
"@rollup/plugin-json": "4.1.0",
4241
"rollup-plugin-replace": "2.2.0",
4342
"rollup-plugin-typescript2": "0.29.0",
44-
"typescript": "4.0.5",
43+
"typescript": "4.2.2",
4544
"@firebase/app-compat": "0.0.900"
4645
},
4746
"repository": {

packages-exp/performance-compat/src/performance.test.ts

+1-5
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,10 @@ import {
2525
} from '../test/util';
2626
import * as perfModularApi from '@firebase/performance-exp';
2727
import { PerformanceCompatImpl } from './performance';
28-
import {
29-
FirebasePerformance
30-
//PerformanceTrace
31-
} from '@firebase/performance-types-exp';
3228

3329
describe('Performance Compat', () => {
3430
let performanceCompat!: PerformanceCompatImpl;
35-
let fakeModularPerformance!: FirebasePerformance;
31+
let fakeModularPerformance!: perfModularApi.FirebasePerformance;
3632

3733
beforeEach(() => {
3834
fakeModularPerformance = getFakeModularPerformance();

packages-exp/performance-compat/src/performance.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,12 @@
1717

1818
import { FirebaseApp } from '@firebase/app-types';
1919
import {
20+
trace,
2021
FirebasePerformance,
2122
// The PerformanceTrace type has not changed between modular and non-modular packages.
2223
PerformanceTrace
23-
} from '@firebase/performance-types-exp';
24+
} from '@firebase/performance-exp';
2425
import { FirebasePerformance as FirebasePerformanceCompat } from '@firebase/performance-types';
25-
import { trace } from '@firebase/performance-exp';
2626
import { FirebaseService } from '@firebase/app-types/private';
2727

2828
export class PerformanceCompatImpl

packages-exp/performance-compat/test/util.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import { FirebaseApp } from '@firebase/app-types';
1919
import {
2020
FirebasePerformance,
2121
PerformanceTrace
22-
} from '@firebase/performance-types-exp';
22+
} from '@firebase/performance-exp';
2323

2424
export function getFakeApp(): FirebaseApp {
2525
return {

0 commit comments

Comments
 (0)