Fix analytics logEvent public signatures

[hsubox76]

eventParams should be an optional argument.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 1fc7741

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[google-oss-bot]

Binary Size Report

Affected SDKs

• @firebase/analytics

  Type	Base (47e035f)	Head (8faed38)	Diff
  main	24.5 kB	24.2 kB	-294 B (-1.2%)

• @firebase/app

  Type	Base (47e035f)	Head (8faed38)	Diff
  browser	11.2 kB	10.8 kB	-353 B (-3.2%)
  esm2017	9.58 kB	9.57 kB	-12 B (-0.1%)
  lite	9.25 kB	8.88 kB	-372 B (-4.0%)
  lite-esm2017	7.88 kB	7.87 kB	-12 B (-0.2%)
  main	10.9 kB	9.93 kB	-1.01 kB (-9.2%)
  module	11.2 kB	10.8 kB	-353 B (-3.2%)
  react-native	10.6 kB	9.64 kB	-999 B (-9.4%)

• @firebase/component

  Type	Base (47e035f)	Head (8faed38)	Diff
  main	6.05 kB	5.63 kB	-412 B (-6.8%)

• @firebase/database

  Type	Base (47e035f)	Head (8faed38)	Diff
  browser	277 kB	274 kB	-2.93 kB (-1.1%)
  esm2017	245 kB	245 kB	+214 B (+0.1%)
  main	280 kB	277 kB	-3.20 kB (-1.1%)
  module	277 kB	274 kB	-2.93 kB (-1.1%)

• @firebase/database-exp

  Type	Base (47e035f)	Head (8faed38)	Diff
  browser	278 kB	274 kB	-3.76 kB (-1.4%)
  esm2017	243 kB	242 kB	-568 B (-0.2%)
  main	280 kB	276 kB	-4.19 kB (-1.5%)
  module	278 kB	274 kB	-3.76 kB (-1.4%)

• @firebase/firestore

  Type	Base (47e035f)	Head (8faed38)	Diff
  main	531 kB	530 kB	-474 B (-0.1%)

• @firebase/firestore-exp

  Type	Base (47e035f)	Head (8faed38)	Diff
  main	505 kB	505 kB	-250 B (-0.0%)

• @firebase/firestore-lite

  Type	Base (47e035f)	Head (8faed38)	Diff
  main	144 kB	143 kB	-247 B (-0.2%)

• @firebase/firestore/bundle

  Type	Base (47e035f)	Head (8faed38)	Diff
  main	527 kB	526 kB	-500 B (-0.1%)

• @firebase/firestore/memory

  Type	Base (47e035f)	Head (8faed38)	Diff
  main	324 kB	324 kB	-462 B (-0.1%)

• @firebase/firestore/memory-bundle

  Type	Base (47e035f)	Head (8faed38)	Diff
  main	321 kB	321 kB	-500 B (-0.2%)

• @firebase/installations

  Type	Base (47e035f)	Head (8faed38)	Diff
  main	22.7 kB	22.2 kB	-486 B (-2.1%)

• @firebase/logger

  Type	Base (47e035f)	Head (8faed38)	Diff
  main	5.75 kB	5.50 kB	-247 B (-4.3%)

• @firebase/performance

  Type	Base (47e035f)	Head (8faed38)	Diff
  main	28.5 kB	28.0 kB	-494 B (-1.7%)

• @firebase/remote-config

  Type	Base (47e035f)	Head (8faed38)	Diff
  main	23.4 kB	22.9 kB	-490 B (-2.1%)

• @firebase/rules-unit-testing

  Type	Base (47e035f)	Head (8faed38)	Diff
  main	12.2 kB	12.5 kB	+302 B (+2.5%)

• @firebase/storage

  Type	Base (47e035f)	Head (8faed38)	Diff
  main	61.2 kB	60.7 kB	-510 B (-0.8%)

• @firebase/storage/exp

  Type	Base (47e035f)	Head (8faed38)	Diff
  main	49.9 kB	50.0 kB	+33 B (+0.1%)

• @firebase/util

  Type	Base (47e035f)	Head (8faed38)	Diff
  main	22.1 kB	24.4 kB	+2.24 kB (+10.1%)

• @firebase/webchannel-wrapper

  Type	Base (47e035f)	Head (8faed38)	Diff
  main	47.2 kB	46.9 kB	-247 B (-0.5%)

• firebase

  Type	Base (47e035f)	Head (8faed38)	Diff
  firebase-app.js	20.2 kB	19.9 kB	-276 B (-1.4%)
  firebase-database.js	193 kB	184 kB	-8.52 kB (-4.4%)
  firebase-performance-standalone.es2017.js	71.9 kB	71.9 kB	-10 B (-0.0%)
  firebase-performance-standalone.js	48.3 kB	48.0 kB	-271 B (-0.6%)
  firebase.js	854 kB	845 kB	-8.96 kB (-1.0%)

Test Logs

• Base (47e035fe): https://github.com/firebase/firebase-js-sdk/actions/runs/561841988
• Head (8faed381): https://github.com/firebase/firebase-js-sdk/actions/runs/600136485

[google-oss-bot]

Size Analysis Report

Affected Products

Diffs between base commit (47e035f) and head commit (8faed38) are too large (182,570 characters) to display.

Please check below links to see details from the original test log.

Test Logs

• Base (47e035f): https://github.com/firebase/firebase-js-sdk/actions/runs/561841988
• Head (8faed38): https://github.com/firebase/firebase-js-sdk/actions/runs/600136485

[Feiyang1]

It should have a changeset.

[hsubox76]

I added a changeset. By default it only wanted to add the firebase package because only packages/firebase/index.d.ts changed but I thought @firebase/analytics should be added so it goes under "analytics" in the changelog.

[Feiyang1]

I don't think we should bump @firebase/analytics since it has no changes. Is the typing correct in @firebase/analytics-types? But even if we need to update @firebase/analytics-types, we should not bump @firebase/analytics