Implement analytics-compat package #4460
Conversation
|
| */ | ||
|
|
||
| import { firebase } from '@firebase/app-compat'; | ||
| import { _FirebaseNamespace } from '@firebase/app-types/private'; |
There was a problem hiding this comment.
FYI, we may have merge conflict with #4461 depending on which one got merged first.
| @@ -226,7 +229,11 @@ export function factory( | |||
| app, | |||
| // Public methods return void for API simplicity and to better match gtag, | |||
| // while internal implementations return promises. | |||
| logEvent: (eventName, eventParams, options) => { | |||
| logEvent: ( | |||
| eventName: string, | |||
There was a problem hiding this comment.
Is it necessary to type them explicitly? Are they not inferred by FirebaseAnalyticsInternal ?
There was a problem hiding this comment.
It used to be fine but after adding the logEvent overloads to analytics-types now it complains if the params aren't typed?
hsubox76
force-pushed
the
ch-analytics-compat
branch
from
632cabe to
6304140
Compare
hsubox76
force-pushed
the
ch-analytics-compat
branch
from
c0f2a28 to
166c3dd
Compare
Create analytics-compat package wrapping analytics-exp. Did not add to
firebasepackage - doesn't seem like most compat packages have been added to it yet.